Closed Bug 981428 Opened 6 years ago Closed 6 years ago

Move OSX -framework flags to moz.build

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Move OSX -framework flags to moz.build
12.29 KB, patch
mshal
: review+
Details | Diff | Splinter Review 
No description provided.
Assignee: nobody → ehsan
Blocks: xulinmozbuild
Attachment #8388230 - Flags: review?(mshal)
Attachment #8388230 - Flags: review?(mh+mozilla)
Attachment #8388230 - Flags: review?(gps)
Comment on attachment 8388230 [details] [diff] [review]
Move OSX -framework flags to moz.build

>diff --git a/dom/plugins/test/testplugin/moz.build b/dom/plugins/test/testplugin/moz.build
>index 678c75f..8b405ea 100644
>--- a/dom/plugins/test/testplugin/moz.build
>+++ b/dom/plugins/test/testplugin/moz.build
>@@ -7,8 +7,11 @@
> DIRS += ['secondplugin', 'javaplugin']
> 
> LIBRARY_NAME = 'nptest'
> 
> FAIL_ON_WARNINGS = not CONFIG['_MSC_VER']
> 
> relative_path = '.'
> include('testplugin.mozbuild')
>+
>+if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'cocoa' and '64' in CONFIG['OS_TEST']:
>+    EXTRA_DSO_LDOPTS += ['-framework Carbon']

Since this came from testplugin.mk, I think these lines need to go into testplugin.mozbuild so it will be included by testplugin/, testplugin/secondplugin, and testplugin/javaplugin.
Attachment #8388230 - Flags: review?(mshal)
Attachment #8388230 - Flags: review?(mh+mozilla)
Attachment #8388230 - Flags: review?(gps)
Attachment #8388230 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/feebf1769138
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.