Closed Bug 981495 Opened 8 years ago Closed 8 years ago

CppEclipse backend should add a resource filter to ignore obj- directories

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(2 files)

Otherwise, especially if you have multiple objdirs, any .h file that gets copied to dist/include appears multiple times in the project, confusing the indexer and making shift-control-R considerably less useful.
Comment on attachment 8388336 [details] [diff] [review]
fix

Review of attachment 8388336 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/backend/cpp_eclipse.py
@@ +189,5 @@
> +                        <name>tree</name>
> +                        <type>30</type>
> +                        <matcher>
> +                                <id>org.eclipse.ui.ide.multiFilter</id>
> +                                <arguments>1.0-name-matches-false-false-obj-*</arguments>

Wow that's a nasty save syntax.

Optional: Ideally we would also exclude the objdir used by the user if it doesn't follow the obj- prefix.
Attachment #8388336 - Flags: review?(bgirard) → review+
Attachment #8388342 - Flags: review?(bgirard) → review+
Depends on: 973770
https://hg.mozilla.org/mozilla-central/rev/252e66958eff
https://hg.mozilla.org/mozilla-central/rev/6e7f5c8e3e83
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.