981498 - Auto Prediction if cancelled gives a space

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[ankit93040]

1.Go to New Message
2.Type the Message in the Text Box
3.Default suggestion starts cancel it by clicking on the x button

Actual result:-
Automatically the cursor moves by a step.

Expected Result:-
The cursor shouldn't move.

Comment 1

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

Remove additional space if a user cancels autocomplete/suggestion by IME.

Add a extra space have already been done when user select one of the suggestions in the candidate list [1], this is necessary because the word is completed after choosing one of the candidates, thus we have to provide a space for user to continue typing. 
But in this case, when user trying to cancel the suggestion, I suspect we don't need to provide extra space because he might want to ignore the candidate and continue the incomplete word. So this patch is trying to remove adding extra space when user dismisses the candidates.

[1]: https://github.com/shamenchens/gaia/blob/Bug981498-RemoveKeyboardAdditionalSpace/apps/keyboard/js/imes/latin/latin.js#L662-L663

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

Extra info: Android + iOS both do not insert a space there. But need feedback from UX first I'd guess.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8400485 [details] [review]
Pull request

Chens,

This looks good to me, but as Jan mentioned, this will need UX input.

Omega,

Could you please confirm the modified behavior is ok?
Thank you.

Comment 4

[Julien Wajsberg [:julienw]]

Just to mention that there is another corner case I saw:
* write some text
* tap at the end of a word to correct it
* press backspace, type something else, choose another word
=> there is now 2 spaces instead of 1

I don't know if this patch corrects this behavior as well?

Comment 5

[Omega Feng [:Omega] [:馮於懋]]

Comment on attachment 8400485 [details] [review]
Pull request

As offline discussion with Sherman, when a user enters some characters, say, "do", he may want a "do" or a "dog". In the original design, 
1) if he wants a "do", he can press Space to skip suggestion and append a space, or he can tap X in suggestion bar to skip suggestion and append a space;
2) if he wants a "dog", he tap "dog" in suggestion bar to use "dog" and append a space;
3) if he wants to modify "do", he presses Back Space rather than tapping X.
So, we should keep 1) & 2) consistent that means we should not change the original design.

Comment 6

[Julien Wajsberg [:julienw]]

In the current design, "1)" will append "dog" if "dog" was highlighted.

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

FYI, Android doesn't show a space, but when you type a new char it will insert one after dismissing a suggestion.

Comment 8

[Julien Wajsberg [:julienw]]

What's the rationale for WONTFIX this?