981539 - [Download Manager] A strange message is displayed when the SD is completely full

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[rafael.marquez]

Attachment: correct.JPG

*Pre-requisites
Having a SD card inserted which is full with 1 Mb free

*Procedure
1. Open browser app
2. Open a webpage whitch  you can download files.
3. Download a file which has a size bigger than the empty space in the sd card.

  A correct error message is displayed "correct.JPG" (attached image)


4. Open a webpage whitch  you can download files.
5. Download a file which has a size bigger than the empty space in the sd card.


*Actual Result
 Two no correct messages are displayed  "no correct 1.JPG" and  "no correct 2.JPG" (attached images)


*Expected Result
The message shown in the screenshot "correct.JPG" is displayed in both cases

Comment 1

[rafael.marquez]

Attachment: no correct 1.JPG

Comment 2

[rafael.marquez]

Attachment: no correct 2.JPG

Comment 3

[rafael.marquez]

Francis, Can you verify if my opinion is correct?

Comment 4

[Francis Djabri [:djabber]]

Hi Rafael, yes that's correct and according to the spec. Thanks for picking up on this.

Comment 5

[rafael.marquez]

Aus,

   According to comment 4, the UI that we should show is this one https://bugzilla.mozilla.org/attachment.cgi?id=8388419 as Gaia does. Furthermore, there are two consecutive error messages.

Thanks a lot

Comment 6

[Aus Lacroix [:aus]]

Currently we do not do any space check before starting a download. Furthermore, it's not always possible for us to do so. Do we not get an error attached to the download object with a state change when the SD card becomes full during download?

Comment 7

[Cristian Rodriguez (:crdlc)]

Yes, this error is displayed when we receive an 'stopped' state with error !== null

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/download/download_notification.js#L82

Comment 8

[Aus Lacroix [:aus]]

OK, good! :) We should be able to add additional checks when we see the error in the Downloads API itself and provide a better error message. Or we could try and get the underlying necko bits that fail to write to disk to provide a better error. We'll see which one makes more sense once I dig into this a little bit more.

Comment 9

[rafael.marquez]

any update to this bug?

Comment 10

[Aus Lacroix [:aus]]

Unfortunately no, this is likely to only get my attention next week as other issues have become more complex than expected.

Comment 11

[Aus Lacroix [:aus]]

OK, this should be easier to fix if we go for the more elaborate solution in bug 982006, if we don't, it will be a minor patch to the External Helper App Service once again to provide the original leaf name of the file when available instead of the temporary filename (and full path! ugh!) of the download.

Comment 12

[Aus Lacroix [:aus]]

I'm hoping now that 982006 has landed that we'll be able to resolve this quickly.

Comment 13

[Aus Lacroix [:aus]]

OK, unfortunately, this will require handling the write errors that occur when running out of space differently than how gecko currently handles them. I should have something tomorrow that fixes the issue (and gets rid of the extra alert).

Comment 14

[Aus Lacroix [:aus]]

Attachment: Patch - v1 - Ensure mTransfer instance in case of failure when OnSaveComplete is called.

Comment 15

[Aus Lacroix [:aus]]

Attachment: Pull Request - Handle new error returned for no disk space.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8401623 [details] [diff] [review]
Patch - v1 - Ensure mTransfer instance in case of failure when OnSaveComplete is called.

r=me

Comment 17

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8401627 [details] [review]
Pull Request - Handle new error returned for no disk space.

Good job, thanks

Comment 18

[Aus Lacroix [:aus]]

Attachment: Patch - v2 - Ensure mTransfer instance in case of failure when OnSaveComplete is called.

* Fixed compile error in release mode by removing unused variable.

Comment 19

[Aus Lacroix [:aus]]

Gaia commit (master): https://github.com/mozilla-b2g/gaia/commit/c8e974e69c764b953263c7474d10c25aa68bb862

Comment 20

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b07cc963d7a1

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b07cc963d7a1

Comment 22

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/c860837d1bb02ed91d9277ff38e9bfec2ae1c99d

https://hg.mozilla.org/releases/mozilla-aurora/rev/b603af7051a9

Comment 23

[rafael.marquez]

Verified in v1.4 and v1.5