Closed Bug 981607 Opened 6 years ago Closed 6 years ago

Ensure that Log may handle both long and long long.

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file)

fix
1.84 KB, patch
botond
: review+
Details | Diff | Splinter Review
Attached patch fix — — Splinter Review 
Bug 958596 changed Log class to use stdint types instead of builtin one. This causes problems with 64-bit mingw builds. The problematic part is logging HRESULT type, which is a typedef to long. long is 32-bit on win64, so it's not covered by int32_t (which uses int) nor int64_t. This means that there is none exactly matching << operator implementation and choosing one of existing is ambiguous. IMO in this case it's safer to overload the operator for all builtin int types so that where will not be similar problems on any platform.
Attachment #8388485 - Flags: review?(botond)
Comment on attachment 8388485 [details] [diff] [review]
fix

Review of attachment 8388485 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks!
Attachment #8388485 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/18d9ef6053d1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.