981617 - "Rounded" methods in Units.h should specify how they round

Status: NEW

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Otherwise it can be confusing, since there are different rounding methods. In particular, in other places we call ToNearest.

Also, it's pretty much always wrong to round a rectangle by rounding its x/y/width/height independently.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 1: Rename CSSPixel::FromAppUnitsRounded to FromAppUnitsToNearest

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8388492 [details] [diff] [review]
Part 1: Rename CSSPixel::FromAppUnitsRounded to FromAppUnitsToNearest

Review of attachment 8388492 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment fixed

Also, can you change the two call sites to CSSIntRect::FromAppUnitsRounded in nsGlobalWindow.cpp to be CSSIntSize::FromAppUnitsRounded? It's misleading that they're called on CSSIntRect when in fact they deal with size properties.

::: layout/base/Units.h
@@ +75,5 @@
>   */
>  struct CSSPixel {
>  
> +  static CSSIntRect FromUntyped(const nsIntRect& aPoint) {
> +    return CSSIntRect(aPoint.x, aPoint.y, aPoint.width, aPoint.height);

s/aPoint/aRect/g