Closed Bug 981640 Opened 6 years ago Closed 10 months ago

Intermittent layout/reftests/svg/smil/transform/paced-1.svg | image comparison (==), max difference: 1, number of differing pixels: 32

Categories

(Core :: SVG, defect, P3)

x86_64
macOS
defect

Tracking

()

RESOLVED INACTIVE

People

(Reporter: RyanVM, Unassigned)

Details

(Keywords: intermittent-failure)

Attachments

(3 files)

Attached image test screenshot
This was previously annotated as fuzzy, but that was removed in bug 981110. The fuzziness is around curved lines like the eyes and mouth.

https://tbpl.mozilla.org/php/getParsedLog.php?id=35877714&tree=Mozilla-Inbound

Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test reftest on 2014-03-10 03:28:24 PDT for push fb23f20f9c6c
slave: talos-mtnlion-r5-064

03:59:18     INFO -  REFTEST TEST-START | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/svg/smil/transform/paced-1.svg
03:59:18     INFO -  REFTEST TEST-LOAD | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/svg/smil/transform/paced-1.svg | 8473 / 10720 (79%)
03:59:18     INFO -  ++DOMWINDOW == 185 (0x1388b46c0) [pid = 1244] [serial = 24168] [outer = 0x10e7757d0]
03:59:18     INFO -  REFTEST TEST-LOAD | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/svg/smil/transform/paced-1-ref.svg | 8473 / 10720 (79%)
03:59:18     INFO -  ++DOMWINDOW == 186 (0x1388abda0) [pid = 1244] [serial = 24169] [outer = 0x10e7757d0]
03:59:18     INFO -  REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/svg/smil/transform/paced-1.svg | image comparison (==), max difference: 1, number of differing pixels: 32
03:59:18     INFO -  REFTEST   IMAGE 1 (TEST): 
03:59:18     INFO -  REFTEST   IMAGE 2 (REFERENCE): 
03:59:18     INFO -  REFTEST INFO | Saved log: START file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/svg/smil/transform/paced-1.svg
03:59:18     INFO -  REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
03:59:18     INFO -  REFTEST INFO | Saved log: Initializing canvas snapshot
03:59:18     INFO -  REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
03:59:18     INFO -  REFTEST INFO | Saved log: [CONTENT] RecordResult fired
03:59:18     INFO -  REFTEST INFO | Saved log: RecordResult fired
03:59:18     INFO -  REFTEST INFO | Saved log: START file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/svg/smil/transform/paced-1-ref.svg
03:59:18     INFO -  REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
03:59:18     INFO -  REFTEST INFO | Saved log: Initializing canvas snapshot
03:59:18     INFO -  REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
03:59:18     INFO -  REFTEST INFO | Saved log: [CONTENT] RecordResult fired
03:59:18     INFO -  REFTEST INFO | Saved log: RecordResult fired
03:59:18     INFO -  REFTEST INFO | Loading a blank page
03:59:18     INFO -  REFTEST TEST-END | file:///builds/slave/talos-slave/test/build/tests/reftest/tests/layout/reftests/svg/smil/transform/paced-1.svg
Attached image reference screenshot
Once the tree reopens, I'll land a patch to add "fuzzy-if(cocoaWidget,1,32)" at the beginning of paced-1.svg's line in the manifest (with a comment pointing to this bug).

rs=RyanVM granted over IRC.
Whiteboard: [leave open]
The 1px difference on Windows (Comment 6 through 10) is a fuzzy pixel at the outer left edge of the bottom-left smiley, FWIW.

Pushing a winWidget-specific fuzzy annotation to silence it:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/a41d8a972b65
Guess we need to make this a bit fuzzier.
Flags: needinfo?(dholbert)
Yup.

The mismatching pixels in the Windows failures in comment 19 & comment 20 (and probably the comments before as well; haven't looked at those) are 4 pixels just outside the rightmost edge of the top-center smileyface. They're white in the reference, and near-white in the testcase.
Landed a patch to increase fuzziness threshold on Windows to "15,4" (up from "1,1" in comment 11), which should take care of the recent reports here:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/d79ed36df3ac
Flags: needinfo?(dholbert)
Keywords: leave-open
Whiteboard: [leave open]
Comment 25 has fuzzy pixels on the upper-left and bottom-right sides of each smiley-face's eyeball-circles, along with one fuzzy pixel near the upper-left of each smiley-face's border.

The test is currently annotated with 32 pixels being fuzzy on Mac. Comment 25 suggests that we should bump that up to 37 pixels. Probably worth waiting for more data first, though, since that was the first failure in ~5 months.
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?
Flags: needinfo?(svoisen)
The fuzzy annotation here isn't severe enough that anyone should reasonably spend time investigating this.

The test still fails without the annotation, so this isn't "fixed"; I guess let's close it as "inactive".
Status: NEW → RESOLVED
Closed: 10 months ago
Flags: needinfo?(svoisen)
Keywords: leave-open
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.