98165 - "Help - About Plugins" crashes browser

Status: VERIFIED DUPLICATE of bug 86642

(Core Graveyard :: Plug-ins, defect, P1)

Description

[Peter Lairo]

Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.3+) Gecko/20010830

"Help - About Plugins" crashes browser.

Possible cause (is so, it shouldn't be): I have copied a few "plugin files from
opera and Nescape 6.1 into my mozilla plugins directory, but these shouldn't
cause the entire browser to crash when selecting "help - about plugins";
especially, if these plugings in fact do work.

Here are the files:

\plugins
file.tmp
NPGetRt1.dll     <---- GetRight for Opera Plugin
NPGetRt2.dll     <---- GetRight for Opera Plugin
NPGetRt3.dll     <---- GetRight for Opera Plugin
NPJava130_01.dll
NPJava130_01a.dll
NPJava130_01b.dll
NPJava130_01c.dll
npnul32.dll
npswf32.dll       <---- shockwave?

\plugins\GetRight
Install.log
Unwise.exe

Comment 1

[Chase Tingley]

*** This bug has been marked as a duplicate of 96015 ***

Comment 2

[Chase Tingley]

The bug I just dup'd to was actually for *reloading* about:plugins, which may or
may not be the same crash as what you see.

I know bug 86591 (plugin topcrash) also talks about crashes related to
about:plugins, however, so I'm not too worried about this crash slipping through
the cracks.

Comment 3

[Peter Lairo]

It's not a dupe of bug 96015 because that bug said you *can* select "help -
about plugins" *without crashing* (see "steps to reproduce" there). This bug
says you cannot even select "help - about plugings" without crashing immediately
- let alone have a chance to select "reload".

The other bug you mention (bug 86591) is only for Linux and also only deals with
*a certain plugin itself causing a crash* when a page needs that pluging.

--> reopening.

BTW. After some more testing, I'm pretty certain the crash is caused by the
GetRight plugin for Opera. I'll attach the pluging files next so you can
test/verify.

Comment 4

[Peter Lairo]

Attachment: GetRight plugin files for testing. Just copy into "plugins" directory

Comment 5

[Peter Lairo]

Attaching a *ZIP* file didn't seem to work. Is there a "mime-type" i need to
enter? Please advise.

Comment 6

[Chase Tingley]

Actually that attachment looks fine.  I saved as a .zip file and was able to
extract the plugins.

Unfortunately, since I'm on linux, I can't actually try to reproduce the bug.

Also I just realized this is an Opera plug-in -- I have no idea if that's even
supposed to work.  (Although obviously it shouldn't crash.)

-> plug-ins

Comment 7

[Peter Lairo]

[OT]
The opera plugin for GetRight does work by catching most downloadable clicks. It
is a nice "interim" solution until the download manager bugs are fixed (see bug
75364).
[/OT]

Comment 8

[Boris Zbarsky [:bzbarsky]]

> Attaching a *ZIP* file didn't seem to work. Is there a "mime-type" i need to
> enter?

application/x-zip is a good one

Comment 9

[Matthias Versen [:Matti]]

I can't test this one because I get with the latest builds an empty 
"About:Plugins" page.
Peter: Do you have a Talkback ID ?

Comment 10

[av (gone)]

Confirming the bug. Of all the plugin files you need npgetrt3.dll only to
reproduce the crash.

Comment 11

[av (gone)]

Attachment: stack trace

Comment 12

[Peter Lubczynski]

Oh cool! Thanks very much on the steps to reproduce, this is my crash.

*** This bug has been marked as a duplicate of 86642 ***

Comment 13

[av (gone)]

Attachment: first try

Comment 14

[Peter Lubczynski]

Andrei beat me to it....looks like the one I was working on....r=peterl on that
patch but I think you should attach it and take ownership of bug 86642 as well.

Comment 15

[shrirang khanzode]

v

Comment 16

[Peter Lairo]

Peter Lubczynski: You duped this bug to a bug that I don't understand. Will the
other bug fix the crash I am getting as a result of having the GetRight plugin
files installed?

Comment 17

[Chase Tingley]

Peter, the answer should be yes -- the stack trace your crash produces is
identical to the one on bug 86642 (which was frequently seen in talkback
reports, but could not be reproduced reliably until this bug was filed).  av's
patch was checked in yesterday afternoon (Sep. 4), so a nightly build with id
20010905xx should fix this crash.

Comment 18

[av (gone)]

Peter Lairo: yes that fix also fixed the GetRight plugin crash. You may want to 
download the latest build to verify that.

Comment 19

[Peter Lairo]

Yes, "help - about plugins" now works with the GetRight plugin installed -> WFM :)