981673 - URL field's "Firefox" identity block separator looks wide/blurry on Windows hidpi

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Gary [:streetwolf52]]

Attachment: Capture1.PNG

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140310043228

Steps to reproduce:

1. Enter about:home in URL bar.  


Actual results:

The separator appears too wide.  Not sure if this is intended or not.


Expected results:

Separator should be consistent with separators in non about: URLs, i.e. thinner.  All about: statements that have a separator are also thicker.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Hm, it doesn't look like 2 pixels wide to me. Maybe the darker color and subpixel anti-aliasing causes it to bleed more?

Comment 2

[Gary [:streetwolf52]]

I don't know if this helps but adding this css code improves the look of the separator:

#nav-bar[currentset*="unified-back-forward-button,urlbar-container"] #forward-button > .toolbarbutton-icon,
#nav-bar-customization-target #forward-button > .toolbarbutton-icon {
  padding-left: 8px !important;}

Comment 3

[Gary [:streetwolf52]]

This problem appears to be fixed now.  I'm running on Inbound atm.  So between my post above and now something fixed my problem.

Comment 4

[Gary [:streetwolf52]]

This problem appears to be fixed now.  I'm running on Inbound atm.  So between my post above and now something fixed my problem.

One thing I now notice is the top border on the Forward arrow is very light, and the bottom border is almost not visible.

Comment 5

[Gary [:streetwolf52]]

Also wanted to mention that the separator between the identity info and the URL (https) looks fainter now.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Please include screenshots. Are you on Windows? Which version? There were some changes to toolbarbuttons recently on Windows 8.

Comment 7

[Gary [:streetwolf52]]

Attachment: Forward button borders.

Top border of forward button might be a little too light.  Bottom border is almost lacking.  Also notice separator line after the identity stuff appears too light IMO.

Comment 8

[Gary [:streetwolf52]]

Attachment: Separator line.

Running Windows 8.1.

Notice the separator line on 'about:' stuff is looking a lot better now.

Comment 9

[Gary [:streetwolf52]]

Attachment: Forward button, another look.

This shot shows both arrows active.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Ok, I'll close this bug then as WorksForMe. Thanks for the follow-up Gary.

Comment 11

[Gary [:streetwolf52]]

Just want to point out that when I look at my attachments they are zoomed which distorts the look.  I have to click on the image to reduce it's size to normal which shows the problem as it really exists.

Comment 12

[Gary [:streetwolf52]]

How about the other problems?

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

The problem with the borders on the forward button should be filed as a separate bug. I don't see any issues with the separators.

Comment 14

[Gary [:streetwolf52]]

The border problem only appears on inbound.  I tried the latest patch on the Nightly hourlies and the borders are OK.

Comment 15

[Gary [:streetwolf52]]

Disregard Comment 14, the problem does appear on the Nightly hourly.

Comment 16

[Greg Edwards]

Gary: In comment 11, you are describing Bug 857089. I agree it's very annoying.

I think most of these issues have to do with the fractional pixels that crop up everywhere on non-int DPI scales. It would be helpful if there was an XUL property to snap dimensions to device pixels. I could even write you a mockup in Javascript if it would help.