981699 - Windows jump around when being restored if they have a size and are maximized

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

The initial window of my nightly session jumps around when starting up Firefox because (probably) OS X opens a maximized window, we then go and all window.resizeTo() only to call window.maximize() shortly after.

We should really omit the resizeTo() call for a currently maximized window that will end up maximized again.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-981699-Skip-resizeTo-call-when-restoring-a-maxim.patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

OMG this is that bug!?

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Yeah... I couldn't find a regression range for this (builds from last year have the same behavior) but I also don't remember when this started happening.

Comment 4

[Steven MacLeod [:smacleod]]

Comment on attachment 8388602 [details] [diff] [review]
0001-Bug-981699-Skip-resizeTo-call-when-restoring-a-maxim.patch

Review of attachment 8388602 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: browser/components/sessionstore/src/SessionStore.jsm
@@ +2783,5 @@
>      if (aWidth && aHeight && (aWidth != win_("width") || aHeight != win_("height"))) {
> +      // Don't resize the window if it's currently maximized and we would
> +      // maximize it again shortly after.
> +      if (aSizeMode != "maximized" || win_("sizemode") != "maximized") {
> +        aWindow.resizeTo(aWidth, aHeight);

With this if a user "un-maximizes" the window, it won't return to the proper pre-maximize dimensions (only in the case where we start with a maximized window right?). I don't think we really need to care about that though, so I'm fine if we don't handle it.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Steven MacLeod [:smacleod] from comment #4)
> With this if a user "un-maximizes" the window, it won't return to the proper
> pre-maximize dimensions (only in the case where we start with a maximized
> window right?). I don't think we really need to care about that though, so
> I'm fine if we don't handle it.

Yes, that's true. I noticed that as well while working on the patch but I think that's less pain than having windows jump around... At least on Mac it doesn't even work right nowadays when restoring a closed window. It however works on Linux where we would still support it for all restored windows other than the initial one.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/c65a149ccb6a

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c65a149ccb6a

Comment 8

[u279076]

Tim, does this need tests?

Comment 9

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Mac OS 10.9.3, Windows 7 64bit and Ubuntu 13.10 32bit using Firefox 31.0 RC (buildID: 	20140714151536).