Closed
Bug 981729
Opened 10 years ago
Closed 7 years ago
Fix sdk/lang/functional#throttle tests
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: jsantell, Unassigned)
Details
Attachments
(1 file)
Sometimes fail, should just use tests in underscore
|
Reporter | |
Comment 1•10 years ago
|
||
TEST-UNEXPECTED-FAIL | tests/test-functional.test throttle | function called again during second throttle period - 3 == 2
|
|
Reporter | |
Comment 2•10 years ago
|
||
Attachment #8388819 -
Flags: review?(evold)
|
||
Updated•10 years ago
|
Attachment #8388819 -
Flags: review?(evold) → review+
|
||
Comment 3•10 years ago
|
||
Looks like that didn't exactly work, gave us https://tbpl.mozilla.org/php/getParsedLog.php?id=35951023&tree=Jetpack TEST-UNEXPECTED-FAIL | tests/test-functional.test throttle args | updated to latest value - 3 == 2 at least once per push, rather than the prior somewhat less frequent rate.
|
||
Comment 4•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/3c7210b8111dfc01308cc7f6fb27328560ae0bb1 Revert "Bug 981729 Fix sdk/lang/functional#throttle tests" for causing bug 981361 This reverts commit 5be6edfa55b250a0416925f158e5b321f99dee05.
|
||
Comment 5•10 years ago
|
||
I've backed this out
Priority: -- → P1
|
|
Reporter | |
Comment 6•10 years ago
|
||
Unassigning myself from bugs I haven't gotten around to
Assignee: jsantell → nobody
|
||
Updated•8 years ago
|
Priority: P1 → --
|
||
Comment 7•7 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1399562
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•