981764 - [Task manager] Homescreen artifact during downscale animation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Diego Wilson [:diego]]

STR:

1. Open contacts app
2. Open settings app
3. Long press home to open task manager
4. Observe upscaled portion homescreen flash in the background during downscale animation.

Comment 3

[Diego Wilson [:diego]]

Attachment: Screen recording

Comment 4

[Diego Wilson [:diego]]

This issue is reproducible on QRD 8x26.

@alive any idea what's going on?

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Might be cards view (task manager issue) because the black overlay should appear soon before seeing homescreen opening animation.

I don't see this in my unagi though :/

Comment 6

[Diego Wilson [:diego]]

It seems this is not reproducible on ICS based devices like Unagi. I reproduced it on a kitkat device. It may also be reproducible on a Jellybean device like nexus 4.

Comment 7

[Aus Lacroix [:aus]]

When we go to the cards view, we actually go to the homescreen first, then show the cards view. The cards view dom elements required for it to function are all in the homescreen / system application so there is no way around this right now. We could possibly ensure that the homescreen / system application has the black overlay enabled before we transition to it... not sure if that will solve the problem though.

Alive, what do you think?

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Works for me, just call homescreenWindow.fadeoOut and homescreenWindow.fadeIn when cardsView is shown / hidden.

Comment 9

[Diego Wilson [:diego]]

This wasn't a problem in v1.3 on the same device. Any idea what changed?

Comment 10

[Preeti Raghunath(:Preeti)]

Gregor,

Can you please help with fixing this on 3/21?

Is it possible?

Comment 11

[Aus Lacroix [:aus]]

:diego, many things have changed around window management, any of them could be causing this.

:preeti, it's already assigned and should land within this spring which ends 3/28, I can't guarantee it for the 21st.

Comment 12

[Aus Lacroix [:aus]]

apologies for the typo, that should read "sprint" not "spring".

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

:aus, are you still working on this bug?

Comment 14

[Aus Lacroix [:aus]]

Yep, I'm stuck on another bug so I'm going to be taking care of this today.

Comment 15

[Preeti Raghunath(:Preeti)]

Aus,

Do you think we can have a patch for this one by 3/27? Please let me know

Comment 16

[Aus Lacroix [:aus]]

Attachment: Pull Request - Added 'cardviewbeforeshow' and 'cardviewbeforeclose'. Made HomescreenLauncher use those new events to fadeOut/fadeIn the Homescreen instance when appropriate.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Unknown
[User impact] if declined: Annoying nagging animation glitch
[Testing completed]: Unit tests, Integration Tests pass, Manually tested on a Keon as well.
[Risk to taking this patch] (and alternatives if risky): Low to no risk.
[String changes made]: None.

Comment 17

[Gregor Wagner [:gwagner]]

Comment on attachment 8396797 [details] [review]
Pull Request - Added 'cardviewbeforeshow' and 'cardviewbeforeclose'. Made HomescreenLauncher use those new events to fadeOut/fadeIn the Homescreen instance when appropriate.

No need for approval. it's already 1.4+

Comment 18

[Aus Lacroix [:aus]]

Neat side effect, it feels more responsive. :)

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8396797 [details] [review]
Pull Request - Added 'cardviewbeforeshow' and 'cardviewbeforeclose'. Made HomescreenLauncher use those new events to fadeOut/fadeIn the Homescreen instance when appropriate.

See github comments

Comment 20

[Diego Wilson [:diego]]

I cherry picked https://github.com/mozilla-b2g/gaia/pull/17607 to v1.4 and it works for me. Thanks Ghislain!

Comment 21

[Aus Lacroix [:aus]]

Fixed on master.

Commit: https://github.com/mozilla-b2g/gaia/commit/6c4c90e31dc523e5d204035daeea3b422f5fc24d

Comment 22

[Ryan VanderMeulen [:RyanVM]]

This has conflicts on v1.4.

Comment 23

[Aus Lacroix [:aus]]

I'll have a patch for 1.4 tomorrow.

Comment 24

[Aus Lacroix [:aus]]

V1.4 Commit: https://github.com/mozilla-b2g/gaia/commit/4c3b2f57f4229c5f36f0d8fd399e65f4db88f104

Comment 25

[Aus Lacroix [:aus]]

1.4 merge is green. We're all done with this one. :)

Comment 26

[Brogan Zumwalt [Inactive]]

New test case needs to be written to address bug.

Comment 27

[KTucker [:KTucker][Inactive 3/4/2016]]

Test case added in moztrap:

https://moztrap.mozilla.org/manage/case/14357/