Closed Bug 981800 Opened 6 years ago Closed 6 years ago

Remove the three-parameter version of ReceiveInputEvent

Categories

(Core :: Panning and Zooming, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

APZCTreeManager has:

  nsEventStatus ReceiveInputEvent(const WidgetInputEvent& aEvent,
                                  ScrollableLayerGuid* aOutTargetGuid,
                                  WidgetInputEvent* aOutEvent);

  nsEventStatus ReceiveInputEvent(WidgetInputEvent& aEvent,
                                  ScrollableLayerGuid* aOutTargetGuid);

The first of these takes an input event and an output event; the second one just modifies the input event in-place. These are redundant, and we should kill the first one. Callers that care can trivially make a copy of the event before they call this function if they want to hold an unmodified copy (almost none of the call sites fall in this category).
Attached patch PatchSplinter Review
Assignee: nobody → bugmail.mozilla
Status: NEW → ASSIGNED
Attachment #8388742 - Flags: review?(botond)
Comment on attachment 8388742 [details] [diff] [review]
Patch

Review of attachment 8388742 [details] [diff] [review]:
-----------------------------------------------------------------

I like this cleanup!
Attachment #8388742 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/aae54a60278d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.