981840 - crashing the image cropping tool

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

STR:

1. start a blank project
2. add an image event from the events tab
3. save and name the project
4. copy that image event
5. paste it
6. open the crop tool on the newly pasted event

Comment 1

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/495/files

This was a fun one.

After looking deeper in the code, I can now give better strs:

1. new project
2. open project editor
3. add image event
4. go to crop it

Expected: should see the cropping tools, and only one set of them. Using them should not crash things.

Actual: looks like we now have two cropping tools, and using it causes crashes.

This is because when we make a new editorHelper, we add a trackeventupdated event that sets up the cropping tools. When the app first loads, it does this.

However, when we load the project editor, we setup a second editor helper using the same butter instance, which causes duplicate events. So if you add or update a track event, it gets two sets of editor helpers listening to it.

The fix is to get the project editor to use the previous editorHelper.

Comment 2

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/f164edfa7c8fa3632ac6e0c25e37da008819ecbc