Closed Bug 981867 Opened 6 years ago Closed 6 years ago

Make the tooltip for the CSS category in the web console more general

Categories

(DevTools :: Console, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 30

People

(Reporter: seth, Assigned: seth)

Details

Attachments

(1 file)

I noticed that the tooltip for the CSS category mentions only "CSS parsing errors". Going forward this will include a broader class of CSS-related warnings and errors, so we should update the tooltip.
A one liner to make the tooltip more general and remove the focus on parsing.
Attachment #8388826 - Flags: review?(mihai.sucan)
Comment on attachment 8388826 [details] [diff] [review]
Make the tooltip for the web console CSS category more general.

Review of attachment 8388826 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8388826 - Flags: review?(mihai.sucan) → review+
https://hg.mozilla.org/mozilla-central/rev/b92450e97780
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
You need to update the entity name of the string, so that localizers will be aware of your change.
Please see https://developer.mozilla.org/en-US/docs/Making_String_Changes

Since Aurora is string frozen it's too late for Firefox 30, but please land a follow up patch on m-c
QA Whiteboard: [qa-]
(In reply to Théo Chevalier [:tchevalier] from comment #5)

Good catch, noticed locally by coincidence, apparently most locales haven’t:
 http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=btnPageCSS.tooltip&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla-aurora

Any action needed?
(In reply to Ton from comment #6)
> (In reply to Théo Chevalier [:tchevalier] from comment #5)
> 
> Good catch, noticed locally by coincidence, apparently most locales haven’t:
>  http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=btnPageCSS.
> tooltip&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla-aurora
> 
> Any action needed?

Yes, opening a bug and attaching a patch. I put that in my TODO if nobody does it before me.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.