Closed
Bug 981867
Opened 9 years ago
Closed 9 years ago
Make the tooltip for the CSS category in the web console more general
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: seth, Assigned: seth)
Details
Attachments
(1 file)
1.44 KB,
patch
|
msucan
:
review+
|
Details | Diff | Splinter Review |
I noticed that the tooltip for the CSS category mentions only "CSS parsing errors". Going forward this will include a broader class of CSS-related warnings and errors, so we should update the tooltip.
Assignee | ||
Comment 1•9 years ago
|
||
A one liner to make the tooltip more general and remove the focus on parsing.
Attachment #8388826 -
Flags: review?(mihai.sucan)
Comment 2•9 years ago
|
||
Comment on attachment 8388826 [details] [diff] [review] Make the tooltip for the web console CSS category more general. Review of attachment 8388826 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8388826 -
Flags: review?(mihai.sucan) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Thanks for the review! Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/b92450e97780
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b92450e97780
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Comment 5•9 years ago
|
||
You need to update the entity name of the string, so that localizers will be aware of your change. Please see https://developer.mozilla.org/en-US/docs/Making_String_Changes Since Aurora is string frozen it's too late for Firefox 30, but please land a follow up patch on m-c
Updated•9 years ago
|
QA Whiteboard: [qa-]
Comment 6•9 years ago
|
||
(In reply to Théo Chevalier [:tchevalier] from comment #5) Good catch, noticed locally by coincidence, apparently most locales haven’t: http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=btnPageCSS.tooltip&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla-aurora Any action needed?
Comment 7•9 years ago
|
||
(In reply to Ton from comment #6) > (In reply to Théo Chevalier [:tchevalier] from comment #5) > > Good catch, noticed locally by coincidence, apparently most locales haven’t: > http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=btnPageCSS. > tooltip&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla-aurora > > Any action needed? Yes, opening a bug and attaching a patch. I put that in my TODO if nobody does it before me.
Updated•5 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•