981867 - Make the tooltip for the CSS category in the web console more general

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Seth Fowler [:seth] [:s2h]]

I noticed that the tooltip for the CSS category mentions only "CSS parsing errors". Going forward this will include a broader class of CSS-related warnings and errors, so we should update the tooltip.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Make the tooltip for the web console CSS category more general.

A one liner to make the tooltip more general and remove the focus on parsing.

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 8388826 [details] [diff] [review]
Make the tooltip for the web console CSS category more general.

Review of attachment 8388826 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Seth Fowler [:seth] [:s2h]]

Thanks for the review!

Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b92450e97780

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b92450e97780

Comment 5

[Théo Chevalier [:tchevalier]]

You need to update the entity name of the string, so that localizers will be aware of your change.
Please see https://developer.mozilla.org/en-US/docs/Making_String_Changes

Since Aurora is string frozen it's too late for Firefox 30, but please land a follow up patch on m-c

Comment 6

[Ton [:Tonnes]]

(In reply to Théo Chevalier [:tchevalier] from comment #5)

Good catch, noticed locally by coincidence, apparently most locales haven’t:
 http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=btnPageCSS.tooltip&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla-aurora

Any action needed?

Comment 7

[Théo Chevalier [:tchevalier]]

(In reply to Ton from comment #6)
> (In reply to Théo Chevalier [:tchevalier] from comment #5)
> 
> Good catch, noticed locally by coincidence, apparently most locales haven’t:
>  http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=btnPageCSS.
> tooltip&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla-aurora
> 
> Any action needed?

Yes, opening a bug and attaching a patch. I put that in my TODO if nobody does it before me.