981906 - [B2G][Browser] No option to close an error page for loading a browser homescreen shortcut

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Rachel Pribble [:rpribble]]

Description:
When user receives an error during loading browser page content, the error page that appears has no close button (as mentioned in test case #4076), only a 'tap to retry' option.

Repro Steps:
Prerequisite: Have a web page saved as an icon on the home screen.
1) Updated buri to BuildID: 20140309160201
2) Tap the saved web page icon on the home screen
3) Drag down the navigation bar and turn on airplane mode quickly while page is loading
4) Observe lack of close button on error page

Actual:
There is no option for the user to close the error page other than force-closing.

Expected:
Case #4076 lists a 'close' button that should be present.

Environmental Variables:
Device: buri v1.4 MOZ ril
BuildID: 20140309160201
Gaia: 6c109df47006b08c082761c0ddd6ba53a864983a
Gecko: 21f293fc8d34
Version: 30.0a1
Firmware Version: v1.2-device.cfg

Notes: Unable to try and repro on v1.3 as web pages load regardless of an error in service and cannot achieve error page.

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/4076/
See attached: Screenshot

Comment 1

[Jason Smith [:jsmith]]

You shouldn't need to hit the airplane mode button that quickly - you just need to disable the network connection before you tap the saved web page icon. Can you confirm the bug reproduces in that case? Also, can you include a screenshot?

Comment 2

[Rachel Pribble [:rpribble]]

Issue does repro when the network connection is disabled before tapping the saved web page icon.
Should also note, v1.3 was previously marked as 'unaffected' but was tested on a reference phone with no sim. Retested on a different phone with a sim to verify and the issue does, in fact, repro on v1.3.

Device: buri v1.3 MOZ
BuildID: 20140310004001
Gaia: 78c30d7ed6f6e30337d6c05453b867f5e97e42bc
Gecko: 00f249d54bda
Version: 28.0
RIL Version:
Firmware Version: v1.2-device.cfg

Comment 3

[Rachel Pribble [:rpribble]]

Attachment: NoCloseButton

Comment 4

[Jason Smith [:jsmith]]

This is a regression from the new offline error UX.

Probably too late to block on this though, as it's easy to workaround.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Note: Christian already found this bug with his work on bug 969267, and his patch there should fix this.

Comment 6

[Gregor Wagner [:gwagner]]

Does this work now? Can we close this bug?

Comment 7

[Montoya Clemmons (MClemmons)]

(In reply to Gregor Wagner [:gwagner] from comment #6)
> Does this work now? Can we close this bug?

This issue reproduces on both 1.4 Buri and 1.3 Buri. Following Comment 2, there is no Close button present on the Unable to connect screen. 

Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140416000203
Gaia: 441c4bcd8ac4f8c01a9bc5a2f8d64eaa87844803
Gecko: a559848a8a00
Version: 30.0a2
Firmware version: v1.2-device.cfg

Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140416004000
Gaia: 11d027ec28d8e8f09c76b35661222499e124abc8
Gecko: ab227cdd984c
Version: 28.0
Firmware version: v1.2-device.cfg

Comment 8

[Cristian Rodriguez (:crdlc)]

The new offline error UX was landed on master (nor 1.3 neither 1.4). It should be fixed in 2.0 with the new UX as Michael said in comment 5

(In reply to Jason Smith [:jsmith] from comment #4)
> This is a regression from the new offline error UX.
> 
> Probably too late to block on this though, as it's easy to workaround.

Comment 9

[Gregor Wagner [:gwagner]]

We won't fix this for 1.3 or 1.4. It's fixed for 2.0