981908 - The separator between 'Bookmark this site' and 'Bookmark menu' shows a dark border at the beginning of the transition when hovering the 'Bookmark this Site' button

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

A regression introduced by a patch in bug 960517. See attached SWF file for video of this happening.

I think there is a border-color of -moz-use-text-color that is getting applied at the beginning of the transition, but I haven't been able to find the exact spot.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Video reproduction (swf)

Comment 2

[Tim Nguyen :ntim]

The 2px border is also a bug.

I have also found another bug related to the bookmarks menu button : When you "drag" the bookmarks menu button, the separator will be missing.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

This was surprisingly difficult to debug, and I don't 100% understand it yet. Something about using -moz-border-end and the border-right-color-ltr-source being set to physical was causing this to happen. I really can't give a thorough explanation, I'm afraid. :/

What I am able to give, is a patch that fixes it.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8394406 [details] [diff] [review]
Patch v1

*shrug*

Comment 5

[Dão Gottwald [:dao]]

Does replacing -moz-border-end: none; with -moz-border-end-style: none; help?

If not, maybe you're running into bug 591600. Does it help if you replace 'transparent' with e.g. 'hsla(210,54%,20%,.0)' here: <http://hg.mozilla.org/mozilla-central/annotate/cf485c48b52f/browser/themes/windows/browser.css#l579>?

Comment 6

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] (on vacation from March 21 to 28) from comment #5)
> If not, maybe you're running into bug 591600. Does it help if you replace
> 'transparent' with e.g. 'hsla(210,54%,20%,.0)' here:
> <http://hg.mozilla.org/mozilla-central/annotate/cf485c48b52f/browser/themes/
> windows/browser.css#l579>?

Err, bug 591600 is about gradients, but may still be remotely related if the problem is how 'transparent' is handled.

Comment 7

[Mike de Boer [:mikedeboer]]

Mike, did you try applying my patch in bug 984976 first? I mentioned in that bug that I didn't see this flickr with the style changes applied there.

Comment 8

[:Gijs (he/him)]

(FWIW, when I reviewed bug 984976, I also didn't see the issue anymore)

Comment 9

[Mike Conley (:mconley) (:⚙️)]

I like freebies. Testing patch for bug 984976 now.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Woo! Bug 984976 takes care of it!

We're done here folks. Sayonara!

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8394406 [details] [diff] [review]
Patch v1

Review of attachment 8394406 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the following change.

::: browser/themes/windows/browser.css
@@ +638,5 @@
> +   * Apparently, for -moz-border-end, even though there's no border here, we still
> +   * need to have a colour assigned to it for when we're hovering the menu button,
> +   * since we transition on the border colour.
> +   */
> +  -moz-border-end: none hsla(210,54%,20%,.2);

Please expand this to:
-moz-border-end-style: none;
-moz-border-end-color: hsla(210,54%,20%,.2);

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Gah - sorry, should have removed the r? on that patch when I WORKSFORME'd this.