981957 - Make browserid_identity's log consistent with other sync logs

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

We want "debug" log messages from browserid_identity to appear in the sync logs to be consistent with the other sync logs.  Also, we want a to be able to flip a single pref and see all log messages dumped to the console.

This means:

* Remove the DumpAppender from browserid_identity.
* Add a default pref to set the log level to Debug.

Then the initLogs function in policies.js will do the right thing and ensure all log output is written to the sync logs.

IMO we want this in 29 so errors reported in the field have debug bid_identity logs.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-981957-make-browserid_identity-s-logs-consistent.patch

Simple patch:
* default the log level to "Debug"
* don't create a separate DumpAppender

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/f25fb5db8893

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f25fb5db8893

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8388947 [details] [diff] [review]
0001-Bug-981957-make-browserid_identity-s-logs-consistent.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): FxA Sync
User impact if declined: Sync logs submitted by users may not have all relevant data
Testing completed (on m-c, etc.): m-c 
Risk to taking this patch (and alternatives if risky): Low
String or IDL/UUID changes made by this patch: None

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/42fa9d46ba5a