Closed Bug 982032 Opened 6 years ago Closed 6 years ago

Can run COMPLETED state twice

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(1 file)

I think we can sometimes run the COMPLETED state of MediaDecoderStateMachine twice.

This happens when multiple decode tasks both call CheckIfDecodeComplete() (which they do at their end). We check if we should be in COMPLETED state, and dispatch an event to run the state machine. But we still do this if we're already in COMPLETED state, so we may end up calling a PlaybackEnded() twice, and dispatching an "ended" event twice.

I think this may be causing bug 907162 to fail again which spiked reproducing after I landed bug 973408.
Attached patch PatchSplinter Review
Don't run COMPLETED case twice.
Attachment #8389081 - Flags: review?(paul)
Attachment #8389081 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/18a5dba931ca
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.