982032 - Can run COMPLETED state twice

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I think we can sometimes run the COMPLETED state of MediaDecoderStateMachine twice.

This happens when multiple decode tasks both call CheckIfDecodeComplete() (which they do at their end). We check if we should be in COMPLETED state, and dispatch an event to run the state machine. But we still do this if we're already in COMPLETED state, so we may end up calling a PlaybackEnded() twice, and dispatching an "ended" event twice.

I think this may be causing bug 907162 to fail again which spiked reproducing after I landed bug 973408.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Don't run COMPLETED case twice.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18a5dba931ca

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/18a5dba931ca