982118 - Move ui.click_hold_context_menus.delay to gfxPrefs

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Oleg Romashin (:romaxa)]

APZC asserting in debug mode due to 
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/GestureEventListener.cpp#88

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Move ui.click_hold_context_menus.delay to gfxPrefs

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8389188 [details] [diff] [review]
Move ui.click_hold_context_menus.delay to gfxPrefs

Review of attachment 8389188 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed. Also please change r=kgupta to r=kats

::: gfx/thebes/gfxPrefs.h
@@ +177,5 @@
>  
>    DECL_GFX_PREF(Live, "nglayout.debug.widget_update_flashing", WidgetUpdateFlashing, bool, false);
>  
>    DECL_GFX_PREF(Once, "webgl.force-layers-readback",           WebGLForceLayersReadback, bool, false);
> +  DECL_GFX_PREF(Live, "ui.click_hold_context_menus.delay",     UiClickHoldContextMenusDelay, int32_t, 500);

I think these are in alphabetical order; please move it up.

Comment 3

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3697a043583b

Comment 4

[Kartikaya Gupta (email:[e-mail])]

You didn't make it alphabetical! Or fix the r=

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage anyway.
https://hg.mozilla.org/integration/mozilla-inbound/rev/63c25c5fa758

https://tbpl.mozilla.org/php/getParsedLog.php?id=35942752&tree=Mozilla-Inbound

Comment 6

[Oleg Romashin (:romaxa)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #4)
> You didn't make it alphabetical! Or fix the r=

I believe I did, but something went wrong, took wrong patch

Comment 7

[Oleg Romashin (:romaxa)]

Attachment: Move ui.click_hold_context_menus.delay to gfxPrefs

One more version with fix for gtests

Comment 8

[Philip Chee]

Comment on attachment 8389572 [details] [diff] [review]
Move ui.click_hold_context_menus.delay to gfxPrefs

> Also please change r=kgupta to r=kats
....
> Bug 982118 - Move ui.click_hold_context_menus.delay to gfxPrefs. r=kgupta
You forgot again

Comment 9

[Oleg Romashin (:romaxa)]

Attachment: Move ui.click_hold_context_menus.delay to gfxPrefs

Comment 10

[Oleg Romashin (:romaxa)]

https://tbpl.mozilla.org/?tree=Try&rev=b842771b7052

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8389766 [details] [diff] [review]
Move ui.click_hold_context_menus.delay to gfxPrefs

Review of attachment 8389766 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits

::: gfx/layers/ipc/GestureEventListener.cpp
@@ +13,3 @@
>  #include "mozilla/gfx/BasePoint.h"      // for BasePoint
>  #include "mozilla/mozalloc.h"           // for operator new
> +#include "gfxPrefs.h"                   // for Preferences

s/Preferences/gfxPrefs/

::: gfx/thebes/gfxPrefs.h
@@ +175,5 @@
>  
>    DECL_GFX_PREF(Once, "layout.frame_rate",                     LayoutFrameRate, int32_t, -1);
>  
>    DECL_GFX_PREF(Live, "nglayout.debug.widget_update_flashing", WidgetUpdateFlashing, bool, false);
> +  DECL_GFX_PREF(Live, "ui.click_hold_context_menus.delay",     UiClickHoldContextMenusDelay, int32_t, 500);

Leave a blank line between the one above and this one.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2d55a9a8785a