Closed Bug 982118 Opened 6 years ago Closed 6 years ago

Move ui.click_hold_context_menus.delay to gfxPrefs

Categories

(Core :: Panning and Zooming, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: romaxa, Assigned: romaxa)

Details

Attachments

(1 file, 2 obsolete files)

Attachment #8389188 - Flags: review?(bugmail.mozilla)
Comment on attachment 8389188 [details] [diff] [review]
Move ui.click_hold_context_menus.delay to gfxPrefs

Review of attachment 8389188 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed. Also please change r=kgupta to r=kats

::: gfx/thebes/gfxPrefs.h
@@ +177,5 @@
>  
>    DECL_GFX_PREF(Live, "nglayout.debug.widget_update_flashing", WidgetUpdateFlashing, bool, false);
>  
>    DECL_GFX_PREF(Once, "webgl.force-layers-readback",           WebGLForceLayersReadback, bool, false);
> +  DECL_GFX_PREF(Live, "ui.click_hold_context_menus.delay",     UiClickHoldContextMenusDelay, int32_t, 500);

I think these are in alphabetical order; please move it up.
Attachment #8389188 - Flags: review?(bugmail.mozilla) → review+
Assignee: nobody → romaxa
Component: Graphics → Panning and Zooming
You didn't make it alphabetical! Or fix the r=
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4)
> You didn't make it alphabetical! Or fix the r=

I believe I did, but something went wrong, took wrong patch
One more version with fix for gtests
Attachment #8389188 - Attachment is obsolete: true
Attachment #8389572 - Flags: review?(bugmail.mozilla)
Comment on attachment 8389572 [details] [diff] [review]
Move ui.click_hold_context_menus.delay to gfxPrefs

> Also please change r=kgupta to r=kats
....
> Bug 982118 - Move ui.click_hold_context_menus.delay to gfxPrefs. r=kgupta
You forgot again
Flags: needinfo?(romaxa)
Attachment #8389572 - Attachment is obsolete: true
Attachment #8389572 - Flags: review?(bugmail.mozilla)
Attachment #8389766 - Flags: review?(bugmail.mozilla)
Flags: needinfo?(romaxa)
Comment on attachment 8389766 [details] [diff] [review]
Move ui.click_hold_context_menus.delay to gfxPrefs

Review of attachment 8389766 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits

::: gfx/layers/ipc/GestureEventListener.cpp
@@ +13,3 @@
>  #include "mozilla/gfx/BasePoint.h"      // for BasePoint
>  #include "mozilla/mozalloc.h"           // for operator new
> +#include "gfxPrefs.h"                   // for Preferences

s/Preferences/gfxPrefs/

::: gfx/thebes/gfxPrefs.h
@@ +175,5 @@
>  
>    DECL_GFX_PREF(Once, "layout.frame_rate",                     LayoutFrameRate, int32_t, -1);
>  
>    DECL_GFX_PREF(Live, "nglayout.debug.widget_update_flashing", WidgetUpdateFlashing, bool, false);
> +  DECL_GFX_PREF(Live, "ui.click_hold_context_menus.delay",     UiClickHoldContextMenusDelay, int32_t, 500);

Leave a blank line between the one above and this one.
Attachment #8389766 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/2d55a9a8785a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.