Closed Bug 982201 Opened 10 years ago Closed 8 years ago

Intermittent browser_net_statistics-01.js | Test timed out | Found a tab after previous test timed out: http://example.com/browser/browser/devtools/netmonitor/test/html_statistics-test-page.html

Categories

(DevTools :: Netmonitor, defect)

Product:
DevTools
Component:
Netmonitor
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox39 fixed, firefox40 fixed, firefox41 fixed, firefox-esr31 wontfix, firefox-esr38 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 41
Tracking Flags:
Tracking Status
firefox39 --- fixed
firefox40 --- fixed
firefox41 --- fixed
firefox-esr31 --- wontfix
firefox-esr38 --- fixed

People

(Reporter: RyanVM, Assigned: sjakthol)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

bug-982201-dont-giveup-so-easily.patch
1.76 KB, patch
sjakthol
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=35943010&tree=Mozilla-Inbound

Rev3 Fedora 12x64 mozilla-inbound debug test mochitest-browser-chrome on 2014-03-11 06:35:24 PDT for push ec47c16ac24d
slave: talos-r3-fed64-049

07:48:01     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_statistics-01.js | There should be a real primed cache chart created now.
07:48:01     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_statistics-01.js | There should be a real empty cache chart created now.
07:48:01     INFO -  --DOMWINDOW == 218 (0x93349a0) [pid = 2988] [serial = 14415] [outer = 0x1129d7a0] [url = about:blank]
07:48:01     INFO -  --DOMWINDOW == 217 (0x10bf24b0) [pid = 2988] [serial = 14425] [outer = 0x97faa40] [url = about:blank]
07:48:01     INFO -  --DOMWINDOW == 216 (0x17a853f0) [pid = 2988] [serial = 14436] [outer = 0xa7e3a80] [url = about:blank]
07:48:01     INFO -  --DOMWINDOW == 215 (0x13c1f900) [pid = 2988] [serial = 14449] [outer = 0xd848b60] [url = about:blank]
07:48:01     INFO -  --DOMWINDOW == 214 (0x5b996e0) [pid = 2988] [serial = 14450] [outer = 0xd0eb000] [url = http://example.com/browser/browser/devtools/netmonitor/test/html_simple-test-page.html]
07:48:01     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_statistics-01.js | Console message: [JavaScript Error: "A promise chain failed to handle a rejection.
07:48:01     INFO -  Date: Tue Mar 11 2014 07:47:19 GMT-0700 (PDT)
07:48:01     INFO -  Full Message: ReferenceError: info is not defined
07:48:01     INFO -  Full Stack: test/</</<@chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-init.js:78:11
07:48:01     INFO -  Handler.prototype.process@resource://gre/modules/Promise.jsm:782:11
07:48:01     INFO -  this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm:661:7
07:48:01     INFO -  " {file: "chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_simple-init.js" line: 78 column: 0 source: "78"}]
07:48:01     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_statistics-01.js | Console message: [JavaScript Error: "showNetworkStatisticsView threw an exception: Error: Timed out while waiting for data
07:48:01     INFO -  Stack: whenDataAvailable/timer<@chrome://browser/content/devtools/netmonitor-controller.js:756:5
07:48:01     INFO -  Line: 756, column: 4" {file: "resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js" line: 56}]
[DOMWINDOW spam]
07:48:27     INFO -  System JS : ERROR /home/cltbld/talos-slave/test/build/tests/mochitest/httpd.js:2836 - TypeError: params.filter(...)[0] is undefined
07:48:27     INFO -  System JS : ERROR /home/cltbld/talos-slave/test/build/tests/mochitest/httpd.js:2878 - TypeError: params.filter(...)[0] is undefined
07:48:28  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_statistics-01.js | Test timed out
07:48:28     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_statistics-01.js | finish() was called, cleaning up...
07:48:28     INFO -  TEST-INFO | MEMORY STAT vsize after test: 3421900800
07:48:28     INFO -  TEST-INFO | MEMORY STAT residentFast after test: 923418624
07:48:28     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_statistics-01.js | finished in 30202ms
07:48:28  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_statistics-01.js | Found a tab after previous test timed out: http://example.com/browser/browser/devtools/netmonitor/test/html_statistics-test-page.html
07:48:28     INFO -  NET-FRONTEND: Destroying the ToolbarView
07:48:28     INFO -  NET-FRONTEND: Destroying the SourcesView
07:48:28     INFO -  NET-FRONTEND: Destroying the NetworkDetailsView
07:48:28     INFO -  NET-FRONTEND: Destroying the CustomRequestView
07:48:28     INFO -  NET-FRONTEND: Destroying the NetMonitorView panes
07:48:28     INFO -  NET-FRONTEND: TargetEventsHandler is disconnecting...
07:48:28     INFO -  NET-FRONTEND: NetworkEventsHandler is disconnecting...
07:48:28     INFO -  --DOCSHELL 0x6894290 == 51 [pid = 2988] [id = 5525]
07:48:28     INFO -  --DOCSHELL 0x19fa470 == 50 [pid = 2988] [id = 5524]
07:48:28     INFO -  [Parent 2988] WARNING: NS_ENSURE_TRUE(mMutable) failed: file /builds/slave/m-in-l64-d-0000000000000000000/build/netwerk/base/src/nsSimpleURI.cpp, line 265
07:48:28     INFO -  [Parent 2988] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/slave/m-in-l64-d-0000000000000000000/build/dom/events/nsDOMEventTargetHelper.h, line 124
07:48:28     INFO -  [Parent 2988] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/slave/m-in-l64-d-0000000000000000000/build/dom/events/nsDOMEventTargetHelper.h, line 124
07:48:28     INFO -  TEST-INFO | checking window state
07:48:28     INFO -  *************************
07:48:28     INFO -  A coding exception was thrown and uncaught in a Task.
07:48:28     INFO -  Full message: ReferenceError: executeSoon is not defined
07:48:28     INFO -  Full stack: waitForTick@chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_statistics-01.js:64:3
07:48:28     INFO -  until/<@chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_statistics-01.js:70:26
07:48:28     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:282:1
07:48:28     INFO -  Handler.prototype.process@resource://gre/modules/Promise.jsm:782:11
07:48:28     INFO -  this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm:661:7
07:48:28     INFO -  *************************
07:48:28     INFO -  *************************
07:48:28     INFO -  A coding exception was thrown and uncaught in a Task.
07:48:28     INFO -  Full message: ReferenceError: executeSoon is not defined
07:48:28     INFO -  Full stack: waitForTick@chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_statistics-01.js:64:3
07:48:28     INFO -  until/<@chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_statistics-01.js:70:26
07:48:28     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:282:1
07:48:28     INFO -  Handler.prototype.process@resource://gre/modules/Promise.jsm:782:11
07:48:28     INFO -  this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm:661:7
07:48:28     INFO -  *************************
There's an artificial two second timeout in whenDataAvailable [1] which is being hit during slow debug tests causing the entire test to fail. IMO it doesn't make sense to give up that easily during tests as we want to test the actual feature - not that it can do everything in under two seconds.

This patch increases the timeout to 45 seconds meaning the timeout won't be hit it tests as the test will time out before whenDataAvailable does.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=abe978f77aae

I tested this idea earlier and the results are colorful but this timeout wasn't hit: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dfccae819c9

[1] https://dxr.mozilla.org/mozilla-central/source/browser/devtools/netmonitor/netmonitor-controller.js#782
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Attachment #8609711 - Flags: review?(past)
Comment on attachment 8609711 [details] [diff] [review]
bug-982201-dont-give-up-so-easily.patch

Review of attachment 8609711 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/netmonitor/netmonitor-controller.js
@@ +799,5 @@
>  };
>  
>  const WDA_DEFAULT_VERIFY_INTERVAL = 50; // ms
> +
> +// Use longer timeout during testing as the tests need this process to succeed

Maybe also mention that the timeout should be longer than the 30 sec mochitest timeout.
Attachment #8609711 - Flags: review?(past) → review+
Comment updated for landing.
Attachment #8609711 - Attachment is obsolete: true
Attachment #8609808 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/db74101d7caa
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.