982215 - Bookmarks toolbar shrinks in size when Bookmarks Toolbar Items is moved out of the Bookmarks toolbar in customization mode

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike de Boer [:mikedeboer]]

STR:

1. Make sure the Bookmarks toolbar is visible
1. Open Customize Mode on OSX nightly
2. Drag the Bookmarks toolbar placeholder button to the nav-bar

Resulting issues that can be seen:
1. The toolbar height jumps to a smaller size when the placeholder is dragged out of it
2. When placed in the nav-bar, the placeholder causes all other toolbar items to be mis-aligned.

Comment 1

[u428464]

Wouldn't this be fixed by fixing bug 734326 ?

Comment 2

[Mike de Boer [:mikedeboer]]

(In reply to Guillaume C. [:ge3k0s] from comment #1)
> Wouldn't this be fixed by fixing bug 734326 ?

No, the placeholder button already has different styling than bookmark items. The problem is that the button inside Customize Mode is misbehaving.

Comment 3

[:Gijs (he/him)]

(In reply to Mike de Boer [:mikedeboer] from comment #0)
> STR:
> 
> 1. Make sure the Bookmarks toolbar is visible
> 1. Open Customize Mode on OSX nightly
> 2. Drag the Bookmarks toolbar placeholder button to the nav-bar
> 
> Resulting issues that can be seen:
> 1. The toolbar height jumps to a smaller size when the placeholder is
> dragged out of it
> 2. When placed in the nav-bar, the placeholder causes all other toolbar
> items to be mis-aligned.

(2) is filed separately already: bug 923156

Comment 5

[:Gijs (he/him)]

Attachment: bookmarks toolbar shrinks when removing the bookmarks toolbar items,

The 19px change is simply reflecting reality - the bookmarks buttons in the navbar are already 18px with a 1px bottom border. The other min-height is new and fixes the issue at hand.

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8406220 [details] [diff] [review]
bookmarks toolbar shrinks when removing the bookmarks toolbar items,

Review of attachment 8406220 [details] [diff] [review]:
-----------------------------------------------------------------

This does fix the issue at hand.

I'm still unhappy about the state we get in when you drag the Personal Toolbar Items on the nav-bar or TabsToolbar... but that has _nothing_ to do with this bug :)

Most importantly, this patch doesn't regress it further.

Comment 7

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/57f2b31da569

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/57f2b31da569

Comment 9

[:Gijs (he/him)]

Comment on attachment 8406220 [details] [diff] [review]
bookmarks toolbar shrinks when removing the bookmarks toolbar items,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a (existed pre-Australis, too)
User impact if declined: toolbar changes size if you remove items off it
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low, CSS-only
String or IDL/UUID changes made by this patch: none

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e0f509476ee4