982229 - Webmaker.org needs LESS linting

Status: RESOLVED INCOMPLETE

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Dmitry Hamabama Yastremskiy]

Webmaker.org needs LESS linting using RECESS.

Comment 1

[Dmitry Hamabama Yastremskiy]

For Webmaker.org needs to be installed grunt-recess module. Updated Gruntfile.js is ready but will fail if grunt-recess module is not installed. I'm not sure what to do next. How to install that module so Travis will pass it? Thanks

Comment 2

[Dmitry Hamabama Yastremskiy]

Attachment: https://github.com/mozilla/webmaker.org/pull/632

Comment 3

[Dmitry Hamabama Yastremskiy]

Package.son was updated with "grunt-recess" devdependency, and "grunt" execution. LESS linting works and shows some LESS errors. I'll try to fix them. Otherwise the fix cannot be landed because Travis doesn't pass it.

Comment 4

[Pomax]

Comment on attachment 8391783 [details] [review]
https://github.com/mozilla/webmaker.org/pull/632

this is checking too many files. For less, you need to lint only the master .less file, so no *.less masking, you'll have to point to the specific top-most .less files, and then they'll do the importing of all their dependencies while linting. Right now it's throwing about a thousand errors because files that require other files are being linted out of order =)

Comment 5

[Dmitry Hamabama Yastremskiy]

Replaced RECESS with LESSLINT and specified style.less as master less file. Also changed variables paths to the actual. Tested on webmaker-suite, it lints and displays some syntax issues in LESS files. However Travis can't find font-awesome.less. Checked the path 1001 times and seems to be correct, also on webmaker-suite it works fine. Beat my head against the wall.

Comment 6

[Dmitry Hamabama Yastremskiy]

Got rid of some LESS linting errors, but there are some left and I'm not sure if I can solve it. Maybe it needs another ticket for it? Please see https://travis-ci.org/Hamabama/webmaker.org/builds/23003187

Comment 7

[Pomax]

these properties are proper "need fixing" issues. max-height: auto means nothing, so should be removed. Likewise, display:inline-block means nothing for floats, so should either be omitter or just block. Remove all three lines, and let's verify it looks exactly the same.

Comment 8

[Dmitry Hamabama Yastremskiy]

Update: removed those 3 lines and tested on vm. Didn't notice any visual issues. Also updated webmaker-language-picker to the latest version. Please consider to land.

Comment 9

[Pomax]

Comment on attachment 8391783 [details] [review]
https://github.com/mozilla/webmaker.org/pull/632

I don't see anything odd, and grunt passes without linting errors, so I'm going to say r+

Comment 10

[Pomax]

Comment on attachment 8391783 [details] [review]
https://github.com/mozilla/webmaker.org/pull/632

if you fix the spacing and rebase, I will merge this in.

Comment 11

[Dmitry Hamabama Yastremskiy]

Sorry for the mess. Spacing fixed and code rebased!

Comment 12

[Chris DeCairos (:cade)]

The webmaker.org site is no longer developed.

https://learning.mozilla.org/blog/whats-next-for-webmaker-tools