982346 - Port event-guides into the Events2 app so it can be in the navigation

Status: RESOLVED FIXED

(Webmaker Graveyard :: Events, defect)

Description

[Cassie McDaniel [:cassiemc]]

We want event-guides  - https://webmaker.org/en-US/event-guides - to be in the subnav for the events app, so it needs to live within the app.

Bear in mind we will have to do the same for /makerparty down the road.

Comment 2

[Gavin Suntop [:gvn]]

Attachment: redpens

Comment 3

[Cassie McDaniel [:cassiemc]]

Comment on attachment 8390133 [details]
redpens

Left some comments on redpen, just a few nits to make it feel warmer and more consistent. Also filed an additional bug 983298 to have another look at more significant design and content improvements later.

Comment 4

[Gavin Suntop [:gvn]]

Attachment: redpens

Comment 5

[Cassie McDaniel [:cassiemc]]

Comment on attachment 8390880 [details]
redpens

Just a couple spacing and alignment issues on mobile. Fix those then R+. Looks much better with the green subheads and icons.

Comment 6

[Gavin Suntop [:gvn]]

Attachment: https://github.com/mozilla/webmaker-events-2/pull/44

Comment 7

[inactivate account for kate]

Comment on attachment 8391302 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/44

Code looks good but needs to be localized

Comment 8

[Gavin Suntop [:gvn]]

Comment on attachment 8391302 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/44

Now with 100% more localization.