Closed Bug 982359 Opened 6 years ago Closed 6 years ago

Intermittent browser_net_filter-03.js | This test exceeded the timeout threshold. It should be rewritten or split up.

Categories

(DevTools :: Netmonitor, defect)

28 Branch
x86_64
Linux
defect
Not set

Tracking

(firefox28 unaffected, firefox29 unaffected, firefox30 fixed, firefox-esr24 unaffected)

RESOLVED FIXED
Firefox 30
Tracking Status
firefox28 --- unaffected
firefox29 --- unaffected
firefox30 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: KWierso, Assigned: vporof)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=35960824&tree=Mozilla-Inbound
slave: talos-r3-fed-032



14:13:00     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_filter-03.js | The displayed status is incorrect.
14:13:00     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_filter-03.js | The displayed status code is incorrect.
14:13:00     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_filter-03.js | The tooltip status is incorrect.
14:13:00     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_filter-03.js | Displayed type: webm
14:13:00     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_filter-03.js | Tooltip type: video/webm
14:13:00     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_filter-03.js | The displayed type is incorrect.
14:13:00     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_filter-03.js | The tooltip type is incorrect.
14:13:00     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_filter-03.js | Destroying the specified network monitor.
14:13:00     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_filter-03.js | Removing tab.
14:13:00     INFO -  NET-FRONTEND: Destroying the ToolbarView
14:13:00     INFO -  NET-FRONTEND: Destroying the SourcesView
14:13:00     INFO -  NET-FRONTEND: Destroying the NetworkDetailsView
14:13:00     INFO -  NET-FRONTEND: Destroying the CustomRequestView
14:13:00     INFO -  NET-FRONTEND: Destroying the NetMonitorView panes
14:13:00     INFO -  NET-FRONTEND: TargetEventsHandler is disconnecting...
14:13:00     INFO -  NET-FRONTEND: NetworkEventsHandler is disconnecting...
14:13:00     INFO -  --DOCSHELL 0x1a5cbcd0 == 136 [pid = 2388] [id = 5377]
14:13:00     INFO -  --DOCSHELL 0x1a4f3858 == 135 [pid = 2388] [id = 5376]
14:13:00     INFO -  [Parent 2388] WARNING: NS_ENSURE_TRUE(mMutable) failed: file /builds/slave/m-in-lx-d-00000000000000000000/build/netwerk/base/src/nsSimpleURI.cpp, line 265
14:13:01     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_filter-03.js | finish() was called, cleaning up...
14:13:01  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_filter-03.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort.
14:13:01     INFO -  TEST-INFO | MEMORY STAT vsize after test: 1619836928
14:13:01     INFO -  TEST-INFO | MEMORY STAT residentFast after test: 653246464
14:13:01     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_filter-03.js | finished in 33330ms
14:13:01     INFO -  TEST-INFO | checking window state
14:13:01     INFO -  TEST-START | chrome://mochitests/content/browser/browser/devtools/netmonitor/test/browser_net_footer-summary.js
I am seeing this on the second chunk of browser chrome on linux32 while running on ec2.  This is new stuff, but we are really pushing hard to get this transitioned next week.

Victor, can you take a look at this?
Flags: needinfo?(vporof)
This test times out during the cleanup stages (as suggested by the "finish() was called, cleaning up..." log just before timeout).
Flags: needinfo?(vporof)
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8391177 - Flags: review+
Keywords: checkin-needed
thanks for the patch and the quick turnaround!
https://hg.mozilla.org/mozilla-central/rev/12914d8e8063
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
(In reply to Victor Porof [:vporof][:vp] from comment #5)
> This test times out during the cleanup stages (as suggested by the "finish()
> was called, cleaning up..." log just before timeout).

The difference between "Test timed out" and this, "This test exceeded the timeout threshold" is that in the former, you hit the timeout and hadn't produced any output for the last 30 seconds, so your test is killed, while in the latter you hit the timeout but had produced output, so you are allowed to finish. Still the right move to double the timeout, it's pointless to spend a lot of time and money on these bugs that are coming because we insist on running tests on VMs that aren't capable of running our tests, but you'll always see the last part of the test in "exceeded the timeout threshold" because the test is allowed to finish (and that's also a hint for times when you do have "Test timed out" - produce more output, and you get to finish and prove that you can finish if you're just given enough time).
QA Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.