98239 - innerHTML on button funkyness

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jeremy M. Dolan]

Go to URL, do the english one... Start and stop...the button gets reaaaly small.
Play with the manual controls and Start again...odd.

That code works fine in IE5 and 5.5.

This works ok if I use an input type=button and change it's .value (the stuff
that's commented out in the source).

If innerHTML is an extention, is there some standard way to change the
<button>'s text?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Yes... just modify the text node that's a child of the button.

Comment 2

[Fabian Guisset]

or alternatively change its value attribute...

Comment 3

[Jeremy M. Dolan]

fair enough. I was having problems because I'm no web developer, and can't
really take the time to read W3's incredibly obtuse DOM spec, for this one small
JS my company needed. All the examples out there on the web I came across used
non-standard stuff like innerHTML.

Someone on #mozilla helpfully showed me removeChild(firstChild) / createTextNode
/ appendChild.

I'm fine with a WONTFIX here, if the time could be better spent on making the
REAL DOM work better, or some introductory docs for users used to the old
proprietary DOMs.

Comment 4

[Simon Weijgers]

Okay, I tried both the innerHTML approach as well as the text node approach but
both cause the button to go haywire.

I've tested this with the latest nightly (2001110921) on linux.

Comment 5

[Simon Weijgers]

Attachment: This test case uses the innerHTML approach to change the button text.

Comment 6

[Simon Weijgers]

Attachment: This test case takes the Text Node approach to change the button's text

Comment 7

[Simon Weijgers]

I've added two test cases. One takes the innerhtml approach to change the button
text the other takes the Text Node approach to change the button text.

Both however as I mentioned in my previous comment exhibit the same problem,
namely the button text is annihilated.

Again, I've tested this with the very latest nightly (2001110921) on Linux.

Comment 8

[Fabian Guisset]

Funky.
bz, any idea what gives with the text node testcase? Sounds like that should
work, really.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Yes, it should.  I remember poking at that code and not seeing obvious errors
that would cause this...  it feels like a form controls bug....

Comment 10

[Boris Zbarsky [:bzbarsky]]

*** Bug 107259 has been marked as a duplicate of this bug. ***

Comment 11

[Boris Zbarsky [:bzbarsky]]

Bug 107259 has a testcase that demonstrates this problem using replaceChild() as 
well....

Comment 12

[Johnny Stenback (:jst)]

Over to rods, formcontrol layout problem.

Comment 13

[Boris Zbarsky [:bzbarsky]]

*** Bug 154475 has been marked as a duplicate of this bug. ***

Comment 14

[Aaron Kaluszka]

This WFM with XBLFC.

Comment 15

[José Jeria]

Attachment: Minimized testcase

Testcase shows that this is still broken. Comment 4 also says that this also
occur if you do the text change via changing the text node.

Using build 2002101308, Windows 2000.

Comment 16

[José Jeria]

Attachment: Testcase using nodeValue

This testcase works fine, changing the button text with
elm.firstChild.nodeValue instead.

Comment 17

[rods (gone)]

-->

Comment 18

[Boris Zbarsky [:bzbarsky]]

Fixed by patch in bug 226016