Closed Bug 982396 Opened 6 years ago Closed 6 years ago

JavaScript strict warning: chrome://browser/content/browser.js, line 2888: reference to undefined property this._shouldWrap

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 32
Tracking Status
firefox31 --- wontfix
firefox32 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

(Whiteboard: [Australis:P5])

Attachments

(1 file)

When I run a debug build of Firefox, I see the following JavaScript warning in the PlacesToolbarHelper code:

JavaScript strict warning: chrome://browser/content/browser.js, line 2888: reference to undefined property this._shouldWrap
Blocks: 944947
we should probably init _shouldWrap in init()
(In reply to Chris Peterson (:cpeterson) from comment #0)
> When I run a debug build of Firefox, I see the following JavaScript warning
> in the PlacesToolbarHelper code:
> 
> JavaScript strict warning: chrome://browser/content/browser.js, line 2888:
> reference to undefined property this._shouldWrap

Aurora or Nightly? What platform?
(In reply to :Gijs Kruitbosch from comment #2)
> Aurora or Nightly? What platform?

Debug build of Nightly 30 on OS X.
P5 assuming this is harmless.
Whiteboard: [Australis:P5]
Initialize _shouldWrap (to false) in init() before calling _setupPlaceholder(), which reads _shouldWrap.

This is the only JS warning logged in a debug build from process start to idle about:home. I was trying to debug an unrelated JS warning and this one was getting in the way. :)
Assignee: nobody → cpeterson
Status: NEW → ASSIGNED
Attachment #8415029 - Flags: review?(mak77)
Comment on attachment 8415029 [details] [diff] [review]
initialize-_shouldWrap.patch

Review of attachment 8415029 [details] [diff] [review]:
-----------------------------------------------------------------

thanks
Attachment #8415029 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/8e6d6acb1efe
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
You need to log in before you can comment on or make changes to this bug.