Open
Bug 982405
Opened 11 years ago
Updated 2 years ago
Avoid Scissor Rect state churn
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
NEW
People
(Reporter: jrmuizel, Unassigned)
Details
Attachments
(1 file)
4.87 KB,
patch
|
BenWa
:
review-
|
Details | Diff | Splinter Review |
I was seeing scissor rect changes showing up in profiles. They seem to be relatively heavy weight on the adreno.
This changes us from a model where there's a default state for the scissor rect to one where we change it only when necessary. This can make things more error prone or less depending on your point of view.
Reporter | ||
Updated•11 years ago
|
Attachment #8389511 -
Attachment is patch: true
Attachment #8389511 -
Attachment mime type: text/x-patch → text/plain
Attachment #8389511 -
Flags: review?(mstange)
Attachment #8389511 -
Flags: review?(bjacob)
Attachment #8389511 -
Flags: review?(bgirard)
Comment 1•11 years ago
|
||
The first patch in bug 971914 covers this too (and I should land that asap).
Comment 2•11 years ago
|
||
Comment on attachment 8389511 [details] [diff] [review]
Avoid Scissor Rect state churn
I'd rather just land mattwoodrow' patch unless there's a good argument posted here to support land this instead.
Attachment #8389511 -
Flags: review?(bgirard) → review-
Updated•11 years ago
|
Attachment #8389511 -
Flags: review?(mstange)
Comment 3•11 years ago
|
||
Comment on attachment 8389511 [details] [diff] [review]
Avoid Scissor Rect state churn
Review of attachment 8389511 [details] [diff] [review]:
-----------------------------------------------------------------
Cancelling review as BenWa r-'d already. I had this comment:
::: gfx/layers/opengl/CompositorOGL.cpp
@@ +576,5 @@
> // Set the viewport correctly.
> mGLContext->fViewport(0, 0, aSize.width, aSize.height);
>
> mHeight = aSize.height;
> + mCurrentScissorRect = Rect(0, 0, aSize.width, aSize.height);
Here, please validate that mCurrentScissorRect as set by the above line is in agreement with the actual GL scissor rect as returned by glGetIntegerv(SCISSOR_BOX) ; or consider making a gl->fScissor call to make sure it does agree; I'm just uncomfortable about having these two pieces of redundant state updated separately and not checked for consistency.
Attachment #8389511 -
Flags: review?(bjacob)
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•