Closed
Bug 982456
Opened 9 years ago
Closed 9 years ago
When hovering a line of the console, highlight the line
Categories
(DevTools :: Console, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: karlcow, Assigned: gl)
References
Details
Attachments
(6 files, 1 obsolete file)
554.46 KB,
image/png
|
Details | |
1010 bytes,
patch
|
vporof
:
review+
dhenein
:
ui-review+
|
Details | Diff | Splinter Review |
72.47 KB,
image/png
|
Details | |
84.49 KB,
image/png
|
Details | |
76.62 KB,
image/png
|
Details | |
77.63 KB,
image/png
|
Details |
when the window is large, the connection in between the error and the line number is not obvious. Highlighting the line by hovering it with the pointer would solve the issue. It's helpful when you need to click the right line number to access the code in the CSS for example.
Updated•9 years ago
|
Blocks: console-output
Priority: -- → P3
Assignee | ||
Comment 1•9 years ago
|
||
Added background colours for line hovers in the console. Got some feedback that this would be very helpful from the other interns.
Attachment #8451759 -
Flags: feedback?(rcampbell)
Comment 2•9 years ago
|
||
On a related note (for which there may be a different bug filed already), can we add a (very subtle) border between each console entry (much like the old Browser Console used to have)? It's sometimes very hard to distinguish where a message starts and were it ends, especially when there's a lot of text per message (spanning across multiple lines). Fixing this bug obviously helps a lot with that, but I wouldn't want to constantly hover over messages to make sense of the output.
Comment 3•9 years ago
|
||
Comment on attachment 8451759 [details] [diff] [review] 982456.patch I'm going to pass this request to Victor for reasons he will understand.
Attachment #8451759 -
Flags: feedback?(rcampbell) → feedback?(vporof)
Comment 4•9 years ago
|
||
Comment on attachment 8451759 [details] [diff] [review] 982456.patch Review of attachment 8451759 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/themes/shared/devtools/webconsole.inc.css @@ +203,5 @@ > + background-color: #f0f8ff !important; > +} > + > +.theme-dark .message:hover { > + background-color: #283B4B !important; Can we please use colors from the palette instead? A common practice at this point is even using the `rgba` values and playing with the opacity.
Attachment #8451759 -
Flags: feedback?(vporof) → feedback+
Comment 5•9 years ago
|
||
Palette: https://developer.mozilla.org/en-US/docs/Tools/DevToolsColors
Assignee | ||
Comment 6•9 years ago
|
||
Updated colours using palettes from https://developer.mozilla.org/en-US/docs/Tools/DevToolsColors
Assignee: nobody → gabriel.luong
Attachment #8451759 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8451789 -
Flags: review?(vporof)
Comment 7•9 years ago
|
||
Comment on attachment 8451789 [details] [diff] [review] 982456.patch Review of attachment 8451789 [details] [diff] [review]: ----------------------------------------------------------------- Looks pretty. I would also try to get some ui feedback on this. Maybe :darrin.
Attachment #8451789 -
Flags: review?(vporof) → review+
Assignee | ||
Updated•9 years ago
|
Attachment #8451789 -
Flags: ui-review?(dhenein)
Comment 8•9 years ago
|
||
If possible can you post screenshots of the various states to be reviewed? Easier for designers and also lets us have a visual record of nits, etc. At that point, I'd be more than happy to review :) Thanks!
Flags: needinfo?(gabriel.luong)
Assignee | ||
Comment 9•9 years ago
|
||
Flags: needinfo?(gabriel.luong)
Assignee | ||
Comment 10•9 years ago
|
||
Assignee | ||
Comment 11•9 years ago
|
||
Assignee | ||
Comment 12•9 years ago
|
||
Comment 13•9 years ago
|
||
Comment on attachment 8451789 [details] [diff] [review] 982456.patch Looks awesome, thanks!
Attachment #8451789 -
Flags: ui-review?(dhenein) → ui-review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 14•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e23a86020a70
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 15•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e23a86020a70
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Updated•9 years ago
|
QA Whiteboard: [good first verify]
Updated•5 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•