Closed Bug 982468 Opened 10 years ago Closed 6 years ago

with lightweight themes, focus effect for address bar and search bar different for Linux; icon colors are dimmed

Categories

(Firefox :: Theme, defect)

29 Branch
All
Linux
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: davemgarrett, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P5])

Affects search plugins and any addon which adds an icon to the address bar.

With a lightweight theme (wallpaper/skin/Persona or whatever they're called now) active, the Firefox theme makes the address and search bars semitransparent. When they're focused, it regains 100% opacity. Under Linux, this is being applied to the icons inside as well as the bar itself.

https://hg.mozilla.org/mozilla-central/file/69fbe69ddb8c/browser/themes/linux/browser.css#l77

For example, install the https://duckduckgo.com/ search plugin. The duck is white in its icon. Then install a dark theme, for example:
https://addons.mozilla.org/en-US/firefox/addon/black-15433/

With the search plugin selected and the theme active, the duck is now grey under Linux until you focus the search bar. It is white under Windows regardless of if you've focused the bar or not.

This same issue affects icons in the address bar as well.

The icons inside these bars should not have their apparent colors changed under Linux. The translucency effect should be applied exactly the same on all platforms.
Whiteboard: [Australis:P5]
Is this still an issue today?
Flags: needinfo?(davemgarrett)
This is no longer applicable.

That said, 4 years ago I was apparently an idiot and did not attach any screenshots, so I'm no 100% sure what the exact effects I was reporting were, and the test case is no longer valid due to changes in search bar behavior. I compared focused and unfocused colors for the Flagfox icon (which I assume is where I noticed this enough to report a bug) in current versions of Firefox and I see no difference in colors, so I assume this was fixed long ago and I forgot about this bug.

Closing as WFM.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(davemgarrett)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.