982580 - Zooming the conversation content is broken

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[Benedikt Pfeifer]

The content of a conversation can't be zoomed at the moment. Neither Ctrl+Plus nor Ctrl+Minus nor Ctrl+Mouse Wheel work on Windows.
Florian confirmed that on Mac. Gestures aren't working neither on Mac.

There are no errors on the error console.

It's still been working in Instantbird 1.5.

Comment 1

[aleth [:aleth]]

Attachment: zoomfix.diff.diff

Ported from browser.xml

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8492726 [details] [diff] [review]
zoomfix.diff.diff

Review of attachment 8492726 [details] [diff] [review]:
-----------------------------------------------------------------

Don't we also need the isSyntheticDocument getter at http://hg.mozilla.org/mozilla-central/rev/29567f7cdd3d#l6.31 to avoid a warning from http://hg.mozilla.org/mozilla-central/rev/29567f7cdd3d#l5.17 when running that code?

Comment 3

[aleth [:aleth]]

Attachment: zoomfix.diff.diff 2

It doesn't cause a warning, but you're right, it's cleaner to include it.

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8493606 [details] [diff] [review]
zoomfix.diff.diff 2

Review of attachment 8493606 [details] [diff] [review]:
-----------------------------------------------------------------

Not causing a warning is probably because by default this.useFullZoom is always true for Instantbird.

Comment 5

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/58a611a12239