Closed
Bug 982629
Opened 12 years ago
Closed 12 years ago
Use a consistent color for bars on GCCrashes
Categories
(Socorro :: Webapp, task)
Socorro
Webapp
Tracking
(Not tracked)
RESOLVED
FIXED
78
People
(Reporter: espressive, Assigned: espressive)
References
()
Details
(Whiteboard: [QA+])
Attachments
(1 file)
Currently the bar graph on GC Crashes uses the four base colors that is used all over crash stats however, for this graph a larger range of color shades is needed to avoid repetition.
Comment 1•12 years ago
|
||
And I would have thought we might want to use a single color as it's basically one single series of data we are displaying, and not tons of different data.
| Assignee | ||
Comment 2•12 years ago
|
||
Sent pull request: https://github.com/mozilla/socorro/pull/1945
| Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #1)
> And I would have thought we might want to use a single color as it's
> basically one single series of data we are displaying, and not tons of
> different data.
You mean literally a single color or, shades of a single color, like for instance here:
http://mbostock.github.io/d3/talk/20111018/choropleth.html
| Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
| Assignee | ||
Comment 4•12 years ago
|
||
Attachment #8389846 -
Flags: review?(kairo)
Comment 5•12 years ago
|
||
attachment 8389846 [details] is much better. We're plotting a single variable as it changes over time, so using the same color indicates continuity. If the color varied it would imply another dimension to the data that we just don't have.
Comment 6•12 years ago
|
||
Comment on attachment 8389846 [details]
Screen Shot 2014-03-12 at 17.34.10.png
+1 to what Lonnen said :)
Attachment #8389846 -
Flags: review?(kairo) → review+
Updated•12 years ago
|
Summary: Use a wider color range for bars on GCCrashes → Use a consistent color for bars on GCCrashes
| Assignee | ||
Comment 7•12 years ago
|
||
(In reply to Chris Lonnen :lonnen from comment #5)
> attachment 8389846 [details] is much better. We're plotting a single
> variable as it changes over time, so using the same color indicates
> continuity. If the color varied it would imply another dimension to the data
> that we just don't have.
Lonnen, you are the graph master :) Thanks for your input, much appreciated.
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #6)
> Comment on attachment 8389846 [details]
> Screen Shot 2014-03-12 at 17.34.10.png
>
> +1 to what Lonnen said :)
Thanks KaiRo
Comment 8•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/5dfcc0bdfedf458f37aeb352be2f588ac847e64b
Fix Bug 982629, use wider range of colors for graph on gc crashes
https://github.com/mozilla/socorro/commit/5a277c93de2ccb0ed854e7f08306b3feaee710ad
Merge pull request #1945 from ossreleasefeed/bug982629-use-wider-range-of-colors-for-graph
Fix Bug 982629, use single color for graph on gc crashes
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Target Milestone: --- → 78
| Assignee | ||
Comment 9•12 years ago
|
||
QA Steps
--------
Graph should now displays bars in a single color.
QA Contact: mbrandt
You need to log in
before you can comment on or make changes to this bug.
Description
•