Closed Bug 982645 Opened 10 years ago Closed 10 years ago

[Gaia] [Build] unit test for preferences.js

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gduan, Assigned: gduan)

Details

Attachments

(1 file, 1 obsolete file)

PR to master
46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review 
write unit test for preferences.js and refactor it.
Assignee: nobody → gduan
Attached file PR to bubble-tea (obsolete) — 
waiting for travis.
Attached file PR to master — 

        Attachment #8389932 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8390986 [details] [review]
PR to master

Hi Yuren,
travis is all green, would you mind to check this patch? Thanks.

        Attachment #8390986 -
        Flags: review?(yurenju.mozilla)

    
    

    
  
Comment on attachment 8390986 [details] [review]
PR to master

looks good if you replace all |edit| with |set| for method name and replace |editDEBUGPref| with |setDebugPref|

        Attachment #8390986 -
        Flags: review?(yurenju.mozilla) → review+

    
    

    
  
Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/442c76ca2a3896ccfb2a131e1a3510232ecf6ef5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: