982646 - refactor async messages code into nsAsyncMessage class

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nathan Froyd [:froydnj]]

All of our async message classes have a lot of duplicated code.  Let's fix
that.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: refactor async messages code into nsAsyncMessage class

This patch pulls out the common code/members found in our async message classes
into a common class, nsAsyncMessage.  Just a little clean-up patch, not urgent
to review.

Comment 2

[Olli Pettay [:smaug] (away May 1 - 8)]

Comment on attachment 8389812 [details] [diff] [review]
refactor async messages code into nsAsyncMessage class

Could you call the new class
mozilla::SameProcessAsyncMessageBase
or some such


+     NS_IMETHOD Run() {
{ should be in the next line

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d24d095da3a4

I renamed it to nsSameProcessAsyncMessageBase.  Finding a suitable |namespace mozilla {}| block in nsFrameMessageManager.h didn't seem proper given all the nsFoo in that file.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d24d095da3a4