Closed
Bug 982646
Opened 9 years ago
Closed 9 years ago
refactor async messages code into nsAsyncMessage class
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
15.24 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
All of our async message classes have a lot of duplicated code. Let's fix that.
![]() |
Assignee | |
Comment 1•9 years ago
|
||
This patch pulls out the common code/members found in our async message classes into a common class, nsAsyncMessage. Just a little clean-up patch, not urgent to review.
Attachment #8389812 -
Flags: review?(bugs)
Comment 2•9 years ago
|
||
Comment on attachment 8389812 [details] [diff] [review] refactor async messages code into nsAsyncMessage class Could you call the new class mozilla::SameProcessAsyncMessageBase or some such + NS_IMETHOD Run() { { should be in the next line
Attachment #8389812 -
Flags: review?(bugs) → review+
![]() |
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d24d095da3a4 I renamed it to nsSameProcessAsyncMessageBase. Finding a suitable |namespace mozilla {}| block in nsFrameMessageManager.h didn't seem proper given all the nsFoo in that file.
Flags: in-testsuite-
![]() |
Assignee | |
Updated•9 years ago
|
Assignee: nobody → nfroyd
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d24d095da3a4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•