Closed Bug 982680 Opened 6 years ago Closed 6 years ago

Fix regress-406572.js to make sense

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

This test isn't testing anything...  Looks like it was initially written backwards, then in bug 577325 "fixed" to be basically a test for "document" being configurable, then in bug 932322 when we tried to make "document" non-configurable "fixed" to be a test for "self" being configurable.

Patch coming up that stops it doing writeln(uneval(window)), which totally breaks with bug 789261, and actually test something useful.
Comment on attachment 8389854 [details] [diff] [review]
Fix regress-406572.js to actually test something useful.

Review of attachment 8389854 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good assuming "window" is supposed to be non-configurable and non-writable both.
Attachment #8389854 - Flags: review?(jwalden+bmo) → review+
IDL is:

  [Unforgeable, Throws,
   CrossOriginReadable] readonly attribute WindowProxy window;

So yes, accessor property, non-configurable, setter is undefined.
Okay, that's not non-configurable and non-writable, then.  But non-configurable and accessor has the same expected semantics as non-configurable and non-writable -- throw, because changes to non-configurable accessors are forbidden.  So the changes are still fine.
Attachment #8389854 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/265e35a94cc5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.