982697 - Custom cursors have random images attached to them

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Elbart]

Attachment: screenshot

Regression-range https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b0e7f63c2138&tochange=d01bf8596d3b
Between Nightly 20140307 and 0308, IIRC.

Moving with the cursor over the images right of the heart-icon (pinterest, facebook etc.) and then straight over one of the big images of the left, the cursor should only change to a looking-glass to signal the option to zoom the image.

But the cursor also has random images attached to it, i.e. the Pinterest-logo or the facebook-logo, see screenshot

Does not happen with HWA disabled.

Comment 1

[Elbart]

The problem might be specific to nVidia-hardware/driver, as it is not happening on a IntelHD-chip for me.

This site is another example: http://www.planetvb.com/modules/newbb/viewtopic.php?topic_id=5531

Comment 2

[Elbart]

Oops.

Comment 3

[Bram Speeckaert]

It is happening on Intel hardware in my case (Intel HD Graphics 4400 and Windows 8.1). My other computer with Windows 7 and ATI Radeon HD4890 is fine, though.

Comment 4

[Elbart]

Narrower regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2ce2bb2668fd&tochange=2ac59d28974c

Comment 5

[Jonathan Watt [:jwatt]]

Of those three it can only be bug 979853. I'm getting on a plane soon for 30+ hours travel, but I'll look at this sometime after that.

Comment 6

[Takanori MATSUURA]

I'm using Intel HD Graphics driver version 10.18.10.3412 on Windows 7 and have the same problem.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Also seeing it here. Try run of bug 979853 backed out:
https://tbpl.mozilla.org/?tree=Try&rev=abb4a3ea7529

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Confirmed that backing out bug 979853 fixes this.

Comment 9

[Justin Wood (:Callek)]

definitely seeing it here:

My current hardware:

Important Modified Preferences
------------------------------

...
gfx.direct3d.last_used_feature_level_idx: 0
...

Graphics
--------

Adapter Description: Intel(R) HD Graphics 4000
Adapter Drivers: igdumdim64 igd10iumd64 igd10iumd64 igdumdim32 igd10iumd32 igd10iumd32
Adapter RAM: Unknown
Device ID: 0x0166
Direct2D Enabled: true
DirectWrite Enabled: true (6.2.9200.16571)
Driver Date: 11-15-2013
Driver Version: 9.18.10.3359
GPU #2 Active: false
GPU Accelerated Windows: 2/2 Direct3D 10
Vendor ID: 0x8086
WebGL Renderer: Google Inc. -- ANGLE (Intel(R) HD Graphics 4000 Direct3D9Ex vs_3_0 ps_3_0)
windowLayerManagerRemote: false
AzureCanvasBackend: direct2d
AzureContentBackend: direct2d
AzureFallbackCanvasBackend: cairo
AzureSkiaAccelerated: 0

I was on the 03-22 version of aurora.

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This is not fixed/is still an issue in the 2014-03-25 nightly.  I still see corruption/random images attached to cursors, e.g. in gmail when hovering near the left side of the message list (around, but not over, the checkboxes).  But it looks like bug 979853 wasn't actually backed out -- why?  It should have been backed out as soon as the issue was identified.  Needs to be backed out on both aurora and trunk.

Comment 11

[Jonathan Watt [:jwatt]]

Sorry, I forgot to assign this to myself so it dropped off my radar during last weeks work week in Taipei. I'll have a fix for this today or else back it out.

Comment 12

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 13

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c08037c50e0

Comment 14

[Jonathan Watt [:jwatt]]

Comment on attachment 8396854 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 979853
User impact if declined: broken custom cursors, probably other things, maybe a security issue
Testing completed (on m-c, etc.): been on m-i for some time, and will be merged to m-c soon
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0c08037c50e0

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b856eb51391b

Comment 17

[Petruta Horea [:phorea]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0

Reproduced on Nightly 30.0a1 2014-03-16. Verified as fixed using Firefox 31 beta 4.