98270 - SetPosition called on null ScrolledView

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[duraid]

see view/src/nsScrollingView.cpp line 750: quick (mindless) fix is to enclose 
code thus:

if(scrolledView) {  /* add this if() */
	scrolledView->SetPosition(-mOffsetX, -mOffsetY);

	Scroll(scrolledview, dx, dy, t2p, 0);

	NotifyScrollPositionDidChange(offsetX, offsetY);
}

Comment 1

[Keyser Sose]

This has a patch we need a review/sr

Comment 2

[Kevin McCluskey (gone)]

Added nsbranch keyword

Comment 3

[Kevin McCluskey (gone)]

Attachment: Patch file for the suggested fix

Comment 4

[Kevin McCluskey (gone)]

Attachment: Patch file for the suggested fix

Comment 5

[Kevin McCluskey (gone)]

Attachment: Patch file for the suggested fix

Comment 6

[Kevin McCluskey (gone)]

Marking nsbranch- for now. Unless this prevents a crash on a known page

Reporter: Is there a page where Mozilla crashes without this fix? 

Comment 7

[karnaze (gone)]

Comment on attachment 50906 [details] [diff] [review]
Patch file for the suggested fix

r=karnaze

Comment 8

[Marc Attinasi]

Comment on attachment 50906 [details] [diff] [review]
Patch file for the suggested fix

sr=attinasi

Comment 9

[Kevin McCluskey (gone)]

Fix checked into the trunk. Marking fixed.

Comment 10

[Kevin McCluskey (gone)]

Thanks! [e-mail]. 

Comment 11

[Kevin McCluskey (gone)]

Worth getting on to the branch.  Extremely low-risk check for null pointer that
may prevent some crashes.

Marking nsbranch+.

Comment 12

[Jaime Rodriguez, Jr.]

check it in - PDT+

Comment 13

[Kevin McCluskey (gone)]

Checked into Mozilla0.9.4 branch

Comment 14

[Chris Petersen]

Not sure how I can verify this issue so I'm verifying on branch per last comments.