Closed Bug 982723 Opened 6 years ago Closed 6 years ago

[DSDS][Dialer] Change uses of mozMobileConnections to mozIccManager

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S3 (14mar)

People

(Reporter: drs, Assigned: drs)

References

Details

(Whiteboard: [ucid:, 1.4, ft:comms])

Attachments

(1 file)

We made a mistake in bug 946866 and used mozMobileConnections everywhere instead of mozIccManager, and we need to switch it over.
Assignee: nobody → drs+bugzilla
Depends on: 946866
Whiteboard: [ucid:, 1.4, ft:comms]
Target Milestone: --- → 1.4 S3 (14mar)
Comment on attachment 8390085 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17137

We don't need to keep the mozMobileConnections check in call_button. In call button, we want to know if the device has several SIMs present or not. Also, the first call to navigator.mozIccManager.iccIds is costly but the next ones are almost no-ops (I forgot to mention that earlier).
With that change, we can remove the mock for mozMobileConnection in tests and the extra new test.

Also, we need the same change in SimPicker.
Attachment #8390085 - Flags: review?(anthony)
Comment on attachment 8390085 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17137

PR updated.
Attachment #8390085 - Flags: review?(anthony)
(In reply to Doug Sherk (:drs) from comment #3)
> Comment on attachment 8390085 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17137
> 
> PR updated.

And again.
Comment on attachment 8390085 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17137

r+ with a small nit.
Attachment #8390085 - Flags: review?(anthony) → review+
https://github.com/mozilla-b2g/gaia/commit/c3df32ee2a812dce336e11b8dc8f853ece29b977
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 946866
No longer blocks: b2g-dsds-1.4, 1.4-comms-committed
No longer depends on: 946866
You need to log in before you can comment on or make changes to this bug.