982761 - Duplicate symbol insanity::_1

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Unable to compile the unit tests in pkixder_tests.cpp because:

 0:03.18 duplicate symbol __ZN8insanity2_1E in:
 0:03.18 ../../security/manager/ssl/tests/gtest/pkixder_tests.o
 0:03.18 ../../security/certverifier/Unified_cpp_security_certverifier0.o

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: 982761-duplicate_symbol.patch

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8389955 [details] [diff] [review]
982761-duplicate_symbol.patch

Review of attachment 8389955 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/insanity/lib/pkixbind.cpp
@@ +19,5 @@
> +
> +namespace insanity {
> +
> +Placeholder1 _1;
> +  

Trailing whitespace.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: fix-linkage.patch

I rebased the patch on top of the current state of mozilla-inbound. This required moving the moz.build entry for pkixbind.cpp to insanity/moz.build. Also, I had to make the code in pkixbind.cpp conditional on _MSC_VER, because on MSVC we use the built-in std::bind implementation.

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

mozilla-inbound is closed. Thanks!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b753b98bcf55

Comment 6

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Brian's .hgrc

Stefan, I'm sorry the patch got pushed with me as the author. Please see my .hgrc in this attachment for how you can configure Mercurial to add your username to your patches automatically (see the "username = ..." line).

Also, your patches will be easier to review if you use the following settings:

[defaults]
diff=-U 8 -p
qdiff=-U 8 -p
qnew = -U

[diff]
unified = 8
showfunc = true

Thanks for fixing this!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b753b98bcf55