Closed Bug 982792 Opened 10 years ago Closed 7 years ago

Fix customization outlines for tabstoolbar and toolbar-menubar so we can unhide them

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Version:
29 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: MattN, Unassigned)

References

Details

(Keywords: ux-consistency, Whiteboard: [Australis:P4+]) 

Backout the patch in bug 978048 and only prevent the outlines on the OSs that they don't work properly on (I think only Windows). The UX of all platforms shouldn't suffer because we don't have time to fix a bug on one.

I can make a patch when I have time.

Phillip, are you fine with this?
Flags: needinfo?(philipp)
(In reply to Matthew N. [:MattN] (away March 10 - 11) from comment #0)
> Backout the patch in bug 978048 and only prevent the outlines on the OSs
> that they don't work properly on (I think only Windows). The UX of all
> platforms shouldn't suffer because we don't have time to fix a bug on one.
> 
> I can make a patch when I have time.
> 
> Phillip, are you fine with this?

Well, the overlap with the window controls affects OS X too.
Which would leave Linux, but there the top part of the outline is cut off by the title bar, so it's not perfect either.

Therefore I'd say we keep that outline removed on all platforms for now.
Flags: needinfo?(philipp)
Let's morph this to track actually fixing the issues as soon as we're in less of a crazy state.
Summary: Show customization outlines in the TabsToolbar (and menubar) on platforms unaffected by bug 978048 → Fix customization outlines for tabstoolbar and toolbar-menubar so we can unhide them
Whiteboard: [Australis:P3-] → [Australis:P4+]
(In reply to Philipp Sackl [:phlsa] from comment #1)
> Well, the overlap with the window controls affects OS X too.

That was a separate bug (bug 979630) which should be addressed I guess.
Depends on: 979630
These were now removed completely.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.