Closed
Bug 982818
Opened 10 years ago
Closed 10 years ago
about:telemetry displays startupInterrupted and debuggerAttached incorrectly
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: Irving, Assigned: Irving)
References
Details
Attachments
(1 file)
|
2.23 KB,
patch
|
vladan
:
review+
|
Details | Diff | Splinter Review |
The telemetry field formatter added as part of bug 846921 causes the Simple Measurements: startupInterrupted and debuggerAttached fields to display as {} rather than 0/1, because these values are passed as JS Number objects rather than unboxed numbers. Though we don't currently have any, RenderObject() will handle objects created with 'new String()' badly too.
|
Assignee | |
Comment 1•10 years ago
|
||
Fixed both ways - RenderObject() does the right thing for boxed types, and TelemetryPing.jsm uses Number to convert booleans to unboxed numbers rather than creating new boxed Number objects.
Attachment #8390130 -
Flags: review?(vdjeric)
|
||
Updated•10 years ago
|
Attachment #8390130 -
Flags: review?(vdjeric) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9ba5ff374b3f
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9ba5ff374b3f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•