Closed Bug 98290 Opened 23 years ago Closed 23 years ago

XPTC invoke on Mac needs to preserve 16-byte stack frame alignment

Categories

(Core :: XPCOM, defect, P1)

Product:
Core
Component:
XPCOM
Platform:
PowerPC
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.5

People

(Reporter: sfraser_bugs, Assigned: beard)

References

Details

(Whiteboard: PDT+ (per grega) [OSX+])

Attachments

(2 files)

Initial attempt to fix stack alignment problems.
1.15 KB, patch
Details | Diff | Splinter Review
xptcinvoke_mac.s patch which works
1.73 KB, patch
Details | Diff | Splinter Review 
On Mac OS X, we are seeing some weird problems where window title bars become 
coloured, and some Nav Services dialogs come up in all the colours of the 
rainbow.

We're told that this issue is likely a problem with stack alignment. We suspect 
that the xpt call glue is not maintaining 16-byte stack frame alignment, as 
specified by the Mac OS Runtime Architectures book.
Keyword loving.
Keywords: nsbranch+, nsenterprise+
this is a stop-ship for osx.
Severity: normal → critical
That last patch (by beard) actually fixes the rainbow-colored Nav Services 
dialog! Yay!

r=beard
sr=sfraser

*** Bug 98731 has been marked as a duplicate of this bug. ***
OS: Mac System 8.5 → MacOS X
Status: NEW → ASSIGNED
Fix checked in on trunk.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: PDT (may we check into 0.9.4?)
if this isn't on the branch, it needs to be. this is stop-ship. reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: --- → mozilla0.9.5
Priority: -- → P1
If this looks good on the trunk, your confident it has been tested and no
regressions then go ahead and check it into the branch. Marking pdt+
Whiteboard: PDT (may we check into 0.9.4?) → PDT (may we check into 0.9.4?), pdt+
Whiteboard: PDT (may we check into 0.9.4?), pdt+ → PDT+ (per grega) [OSX+]
This has been running in the trunk build since 9/10/2001. I will check into 
the branch today.
Fix checked into 094 branch.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
*** Bug 102117 has been marked as a duplicate of this bug. ***
I'd like to mark this verified.  I have not observed this rainbow color behavior
in the window titles or dialogs on the branch builds 094 and I have not heard
more mention of this on the trunk builds.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: