Closed
Bug 98290
Opened 24 years ago
Closed 24 years ago
XPTC invoke on Mac needs to preserve 16-byte stack frame alignment
Categories
(Core :: XPCOM, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla0.9.5
People
(Reporter: sfraser_bugs, Assigned: beard)
References
Details
(Whiteboard: PDT+ (per grega) [OSX+])
Attachments
(2 files)
|
1.15 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.73 KB,
patch
|
Details | Diff | Splinter Review |
On Mac OS X, we are seeing some weird problems where window title bars become
coloured, and some Nav Services dialogs come up in all the colours of the
rainbow.
We're told that this issue is likely a problem with stack alignment. We suspect
that the xpt call glue is not maintaining 16-byte stack frame alignment, as
specified by the Mac OS Runtime Architectures book.
|
Assignee | |
Comment 3•24 years ago
|
||
|
Reporter | |
Comment 4•24 years ago
|
||
|
|
Reporter | |
Comment 5•24 years ago
|
||
That last patch (by beard) actually fixes the rainbow-colored Nav Services
dialog! Yay!
|
|
Assignee | |
Comment 6•24 years ago
|
||
r=beard
|
|
Reporter | |
Comment 7•24 years ago
|
||
sr=sfraser
|
||
Updated•24 years ago
|
OS: Mac System 8.5 → MacOS X
|
|
Assignee | |
Comment 9•24 years ago
|
||
Fix checked in on trunk.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•24 years ago
|
Whiteboard: PDT (may we check into 0.9.4?)
|
||
Comment 10•24 years ago
|
||
if this isn't on the branch, it needs to be. this is stop-ship. reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: --- → mozilla0.9.5
|
|
||
Updated•24 years ago
|
Priority: -- → P1
|
||
Comment 11•24 years ago
|
||
If this looks good on the trunk, your confident it has been tested and no
regressions then go ahead and check it into the branch. Marking pdt+
Whiteboard: PDT (may we check into 0.9.4?) → PDT (may we check into 0.9.4?), pdt+
|
||
Updated•24 years ago
|
Whiteboard: PDT (may we check into 0.9.4?), pdt+ → PDT+ (per grega) [OSX+]
|
|
Assignee | |
Comment 12•24 years ago
|
||
This has been running in the trunk build since 9/10/2001. I will check into
the branch today.
|
|
Assignee | |
Comment 13•24 years ago
|
||
Fix checked into 094 branch.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
|
||
Comment 14•24 years ago
|
||
*** Bug 102117 has been marked as a duplicate of this bug. ***
|
||
Comment 15•24 years ago
|
||
I'd like to mark this verified. I have not observed this rainbow color behavior
in the window titles or dialogs on the branch builds 094 and I have not heard
more mention of this on the trunk builds.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•