982964 - [gtk3] Combo boxes have white text

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Hubert Figuiere [:hub]]

Attachment: screenshot

I built Firefox with Gtk3 support on Fedora 20. I use Gnome3 with the default theme.

The combo box have white text which make them hard if not impossible to read.

See screenshot.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Which theme do you run and which Firefox version?

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Yes, I can see it now, it's Fedora 20 only.

Comment 3

[Hubert Figuiere [:hub]]

Default theme on Fedora 20 and 175595:210213ae7c1c from mozilla-inbound (build from source)

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: button text patch

We use a wrong color for the button text in the hover event. It should be the label color, not button color.

Comment 5

[Hubert Figuiere [:hub]]

It fixes the hover, indeed - which I also observed but didn't really report. But still not the combo boxes.

It still look like that on the screenshot.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

(In reply to Hubert Figuiere [:hub] from comment #5)
> It fixes the hover, indeed - which I also observed but didn't really report.
> But still not the combo boxes.

I see. It's because comboboxes on the web page uses a different color than comboboxes in Chrome (Menu/Preferences).

Comment 7

[Martin Stránský [:stransky] (ni? me)]

I's because this mechanism:

gtk_container_add(GTK_CONTAINER(combobox), comboboxLabel);

no longer works. The combobox does not have set "has-entry" property and the label is not considered as a combobox entry. We need to create a combobox with entry and get the entry from combobox.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Attachment: wip

Try: https://tbpl.mozilla.org/?tree=Try&rev=2bc6b313f474

Comment 9

[Hubert Figuiere [:hub]]

Oh yeah this is so much better. Thanks !!!

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Attachment: combobox text patch

Comment 11

[Karl Tomlinson (:karlt)]

Comment on attachment 8399816 [details] [diff] [review]
combobox text patch

(Label was probably the wrong type of widget for GTK2 also.)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69ea6095a7aa
https://hg.mozilla.org/integration/mozilla-inbound/rev/a288dcaadccc

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/69ea6095a7aa
https://hg.mozilla.org/mozilla-central/rev/a288dcaadccc

Comment 14

[u279076]

Hubert, can you confirm this issue is resolved?

Comment 15

[Hubert Figuiere [:hub]]

I can't I stopped building for gtk3 because of another blocker....

Comment 16

[Mike Hommey [:glandium]]

Anyone can confirm by using the builds from the elm project branch.

Comment 17

[u279076]

(In reply to Mike Hommey [:glandium] from comment #16)
> Anyone can confirm by using the builds from the elm project branch.

Thanks.

Comment 18

[u279076]

Sorry, wrong flag.

Comment 19

[Catalin Varga [QA][:VarCat]]

We only found elm Firefox builds for Firefox 33 linux x64. Can someone provide us with a Firefox 31 elm build in order to verify the bug?

Comment 20

[Mike Hommey [:glandium]]

Gtk+3 is a work in progress currently, and there were many problems in 31 with its. It may not even build. The first version that kind of works in 32, but really, I think it's not worth worrying more than 33 at this point.

Comment 21

[u279076]

Thanks Mike.