Closed Bug 982964 Opened 7 years ago Closed 7 years ago

[gtk3] Combo boxes have white text

Categories

(Core :: Widget: Gtk, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31
Tracking Status
firefox31 --- fixed

People

(Reporter: hub, Assigned: stransky)

References

Details

Attachments

(3 files, 1 obsolete file)

Attached image screenshot
I built Firefox with Gtk3 support on Fedora 20. I use Gnome3 with the default theme.

The combo box have white text which make them hard if not impossible to read.

See screenshot.
Blocks: gtk3
Which theme do you run and which Firefox version?
Flags: needinfo?(hub)
Yes, I can see it now, it's Fedora 20 only.
Flags: needinfo?(hub)
Default theme on Fedora 20 and 175595:210213ae7c1c from mozilla-inbound (build from source)
We use a wrong color for the button text in the hover event. It should be the label color, not button color.
Attachment #8398448 - Flags: review?(karlt)
It fixes the hover, indeed - which I also observed but didn't really report. But still not the combo boxes.

It still look like that on the screenshot.
Attachment #8398448 - Flags: review?(karlt) → review+
Keywords: checkin-needed
Whiteboard: [leave open for remaining patches]
(In reply to Hubert Figuiere [:hub] from comment #5)
> It fixes the hover, indeed - which I also observed but didn't really report.
> But still not the combo boxes.

I see. It's because comboboxes on the web page uses a different color than comboboxes in Chrome (Menu/Preferences).
I's because this mechanism:

gtk_container_add(GTK_CONTAINER(combobox), comboboxLabel);

no longer works. The combobox does not have set "has-entry" property and the label is not considered as a combobox entry. We need to create a combobox with entry and get the entry from combobox.
Assignee: nobody → stransky
Oh yeah this is so much better. Thanks !!!
Attachment #8399438 - Attachment is obsolete: true
Attachment #8399816 - Flags: review?(karlt)
Keywords: checkin-needed
Whiteboard: [leave open for remaining patches]
Comment on attachment 8399816 [details] [diff] [review]
combobox text patch

(Label was probably the wrong type of widget for GTK2 also.)
Attachment #8399816 - Flags: review?(karlt) → review+
Keywords: checkin-needed
Blocks: 1034064
No longer blocks: 1034064
Hubert, can you confirm this issue is resolved?
Flags: needinfo?(hub)
I can't I stopped building for gtk3 because of another blocker....
Flags: needinfo?(hub)
Anyone can confirm by using the builds from the elm project branch.
(In reply to Mike Hommey [:glandium] from comment #16)
> Anyone can confirm by using the builds from the elm project branch.

Thanks.
Sorry, wrong flag.
We only found elm Firefox builds for Firefox 33 linux x64. Can someone provide us with a Firefox 31 elm build in order to verify the bug?
Flags: needinfo?(mh+mozilla)
Gtk+3 is a work in progress currently, and there were many problems in 31 with its. It may not even build. The first version that kind of works in 32, but really, I think it's not worth worrying more than 33 at this point.
Flags: needinfo?(mh+mozilla)
Thanks Mike.
QA Whiteboard: [qa-]
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.