Closed Bug 982986 Opened 10 years ago Closed 7 years ago

browserid_identity's "isInitialSync" is confusingly named

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: Gavin, Unassigned)

Details

It currently is passed as true to all initializeWithCurrentIdentity calls that are the result of an onlogin notification (i.e. that are triggered by signing in on about:accounts), so it's not only "initial sync" - it's "syncs after login/reauth".

We're currently depending on that for bug 982241 for the UI to update correctly (by depending on weave:service:setup-complete, which is only fired when isInitialSync is true).

So probably what we should do is just rename the parameter.
no longer relevant
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.