Closed Bug 982990 Opened 9 years ago Closed 8 years ago
Breakdown: Improve UI of detaching tabs
+++ Breakdown of Bug #674925 +++
No longer blocks: fxdesktopbacklog
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Whiteboard: p=8 [qa-] → p=8 s=it-32c-31a-30b.3 [qa-]
I made a couple of changes to the latest patch in bug 674925 to get the basics of it to work. The following is a list of work to be done: - Remove the hidden attribute handling to fix the popup appearing. This makes the existing patch at least have a limited level of working - Fix up basic tabstrip dragging. This involves improving the patch to have proper integration with the existing animations when rearranging tabs on the same window. This is broken currently. - Improve the popup appearance on all platforms - Remove the tab from the tabstrip when dragging and slide/animate other tabs inwards - When hovering/dragging over a tabstrip, add space for the tab if it were to be dropped there, instead of using placemarkers - Bug 666864 - fix hover when drag ends - Handle dragging app-tabs. Unsure about this, but is mentioned in comment 42 - Transition the tab into a panel a drag starts - Transition the tab when dropped on a tab bar - Transition the tab when dropped such that it should open a new window, likely by having a window open smaller and grow larger using a transform - Handle when the last tab is dragged. This will allow dragging a tab to combine it onto another window. Should it transition? It should close the window when dropped. - Drag and drop onto bookmarks toolbar. The current code allows dropping tabs in a variety of places and treats them like urls. See comment 70 for a list. However, the patch only allows dropping onto tabs or windows I think, although I didn't test extensively. Should this compatibility be supported? - On Mac, dragging to the dock and onto another application causes the popup to disappear. Likely, similar issues on other platforms when dragging between applications, virtual spaces, etc. - Test dragging between multiple monitors - Drag popups don't slide back if the drag is cancelled. Is this important enough? Safari doesn't do this and Chrome, oddly, treats it as an accepted drag. - Address issue described by comment 78 - Address issue described by comment 83 - Address issue described by comment 91 which can still be reproduced - Ensure that issue described by comment 97 is indeed fixed as indicated by comment 110
Summary: Breakdown: Use drag & drop API for tab detaching → Breakdown: Improve UI of detaching tabs
Some quick thoughts upon reading through the list: > - Handle when the last tab is dragged. This will allow dragging a tab to combine > it onto another window. Should it transition? It should close the window when > dropped. From the discussion in bug 674925 I'm assuming we're using a model similar to IE, right? In this case the window frame should just disappear (ore ideally: fade out) once the tab gets dragged outside the frame. > - Drag popups don't slide back if the drag is cancelled. Is this important enough? > Safari doesn't do this and Chrome, oddly, treats it as an accepted drag. This could be a follow-up, but I don't think it is needed for shipping.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.