Closed Bug 983049 Opened 6 years ago Closed 6 years ago

Rename nsEventDispatcher to mozilla::EventDispatcher

Categories

(Core :: DOM: Events, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(6 files)

No description provided.
DispatchingCallback is not clear to me. Therefore, I name it EventDispatchingCallback.
Attachment #8392118 - Flags: review?(bugs)
Attachment #8392114 - Flags: review?(bugs) → review+
Attachment #8392115 - Flags: review?(bugs) → review+
Attachment #8392117 - Flags: review?(bugs) → review+
Attachment #8392118 - Flags: review?(bugs) → review+
Comment on attachment 8392119 [details] [diff] [review]
part.5 Rename nsEventDispatcher to mozilla::EventDispatcher

You can really remove
-#ifdef CreateEvent
-#undef CreateEvent
-#endif
?

IIRC Windows was doing something odd, and CreateEvent was there in the global scope. So, make sure to build this on Windows too.
Attachment #8392119 - Flags: review?(bugs) → review+
Comment on attachment 8392120 [details] [diff] [review]
part.6 Move remaining stuff in EventDispatcher.cpp into mozilla namespace

You should remove
extern void NS_ShutdownEventTargetChainRecycler(); from nsLayoutStatics.cpp
Attachment #8392120 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #7)
> You can really remove
> -#ifdef CreateEvent
> -#undef CreateEvent
> -#endif
> ?

Yes, in mozilla/EventDispatcher.h, it's done. I.e., if cpp files include mozilla/EventDispatcher.h, they don't need to do it themselves.

I realized that we can remove it in more files. But I'll file follow up bug for it.

(In reply to Olli Pettay [:smaug] from comment #8)
> Comment on attachment 8392120 [details] [diff] [review]
> part.6 Move remaining stuff in EventDispatcher.cpp into mozilla namespace
> 
> You should remove
> extern void NS_ShutdownEventTargetChainRecycler(); from nsLayoutStatics.cpp

good catch! Thanks!
You need to log in before you can comment on or make changes to this bug.