983049 - Rename nsEventDispatcher to mozilla::EventDispatcher

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

Attachment: part.1 Rename nsEventChainVisitor to mozilla::EventChainVisitor

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

Attachment: part.2 Rename nsEventChainPreVisitor to mozilla::EventChainPreVisitor

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

Attachment: part.3 Rename nsEventChainPostVisitor to mozilla::EventChainPostVisitor

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

Attachment: part.4 Rename nsDispatchingCallback to mozilla::EventDispatchingCallback

DispatchingCallback is not clear to me. Therefore, I name it EventDispatchingCallback.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

Attachment: part.5 Rename nsEventDispatcher to mozilla::EventDispatcher

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

Attachment: part.6 Move remaining stuff in EventDispatcher.cpp into mozilla namespace

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8392119 [details] [diff] [review]
part.5 Rename nsEventDispatcher to mozilla::EventDispatcher

You can really remove
-#ifdef CreateEvent
-#undef CreateEvent
-#endif
?

IIRC Windows was doing something odd, and CreateEvent was there in the global scope. So, make sure to build this on Windows too.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8392120 [details] [diff] [review]
part.6 Move remaining stuff in EventDispatcher.cpp into mozilla namespace

You should remove
extern void NS_ShutdownEventTargetChainRecycler(); from nsLayoutStatics.cpp

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

(In reply to Olli Pettay [:smaug] from comment #7)
> You can really remove
> -#ifdef CreateEvent
> -#undef CreateEvent
> -#endif
> ?

Yes, in mozilla/EventDispatcher.h, it's done. I.e., if cpp files include mozilla/EventDispatcher.h, they don't need to do it themselves.

I realized that we can remove it in more files. But I'll file follow up bug for it.

(In reply to Olli Pettay [:smaug] from comment #8)
> Comment on attachment 8392120 [details] [diff] [review]
> part.6 Move remaining stuff in EventDispatcher.cpp into mozilla namespace
> 
> You should remove
> extern void NS_ShutdownEventTargetChainRecycler(); from nsLayoutStatics.cpp

good catch! Thanks!

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(still sick)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c626ba48ddf
https://hg.mozilla.org/integration/mozilla-inbound/rev/91778ceb580b
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3964cfadc3c
https://hg.mozilla.org/integration/mozilla-inbound/rev/b17a1bc1437d
https://hg.mozilla.org/integration/mozilla-inbound/rev/29757c0fa591
https://hg.mozilla.org/integration/mozilla-inbound/rev/735beb5ce026

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5c626ba48ddf
https://hg.mozilla.org/mozilla-central/rev/91778ceb580b
https://hg.mozilla.org/mozilla-central/rev/d3964cfadc3c
https://hg.mozilla.org/mozilla-central/rev/b17a1bc1437d
https://hg.mozilla.org/mozilla-central/rev/29757c0fa591
https://hg.mozilla.org/mozilla-central/rev/735beb5ce026