983066 - assertion failure: Samples missing: 'startTicks == TimeToTicksRoundUp(inputTrackRate, outputStart)' in AudioNodeExternalInputStream.cpp

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P2)

Description

[Karl Tomlinson (:karlt)]

STR
1. Load attachment 831234 [details]

###!!! ASSERTION: Samples missing: 'startTicks == TimeToTicksRoundUp(inputTrackRate, outputStart)', file /home/karl/moz/dev/content/media/AudioNodeExternalInputStream.cpp, line 379

This is from adding more null samples than expected when the track has ended and inputStartTicks > inputTrackEndPoint at
http://hg.mozilla.org/mozilla-central/annotate/c12c92db5588/content/media/AudioNodeExternalInputStream.cpp#l415

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: pad out resampler input past track end only to the end of the block

Comment 2

[Martin Thomson [:mt:]]

What's the status of this bug.

Comment 3

[Maire Reavy [:mreavy]]

Hi Karl, To Martin's question in Comment 2, are you ready to land now that you have your r+ from Paul?  Thanks.

Comment 4

[Karl Tomlinson (:karlt)]

Please feel free to land this if it is blocking anything.

I was delaying landing this, waiting for bug 818822, because the old code may have unintentionally made bug 983062 slightly less significant sometimes.
But I expect the effects of bug 983062 would usually not be noticeable, due to being at the end of the audio, which usually fades out.

Comment 5

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7036a21d1a4

(In reply to Karl Tomlinson (:karlt) from comment #0)
> STR
> 1. Load attachment 831234 [details]

I meant attachment 831235 [details].

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b7036a21d1a4