Closed Bug 983066 Opened 6 years ago Closed 6 years ago
assertion failure: Samples missing: 'start
Ticks == Time To Ticks Round Up(input Track Rate, output Start)' in Audio Node External Input Stream .cpp
STR 1. Load attachment 831234 [details] ###!!! ASSERTION: Samples missing: 'startTicks == TimeToTicksRoundUp(inputTrackRate, outputStart)', file /home/karl/moz/dev/content/media/AudioNodeExternalInputStream.cpp, line 379 This is from adding more null samples than expected when the track has ended and inputStartTicks > inputTrackEndPoint at http://hg.mozilla.org/mozilla-central/annotate/c12c92db5588/content/media/AudioNodeExternalInputStream.cpp#l415
What's the status of this bug.
Hi Karl, To Martin's question in Comment 2, are you ready to land now that you have your r+ from Paul? Thanks.
Please feel free to land this if it is blocking anything. I was delaying landing this, waiting for bug 818822, because the old code may have unintentionally made bug 983062 slightly less significant sometimes. But I expect the effects of bug 983062 would usually not be noticeable, due to being at the end of the audio, which usually fades out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7036a21d1a4 (In reply to Karl Tomlinson (:karlt) from comment #0) > STR > 1. Load attachment 831234 [details] I meant attachment 831235 [details].
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.