983075 - [MADAI][Clock] @2.25x assets update for Clock

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Helen Huang [:HHuang]]

Attachment: [e-mail]

Comment 1

[Helen Huang [:HHuang]]

Hi Marcus,
We would like to update 2.25x assets for Madai, could someone help with it?

Comment 2

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17653

I'll take this. James, flagging you only because you're the UI wizard. From what I can tell, we can just drop these in without any code changes...?

Comment 3

[James Burke [:jrburke]]

Comment on attachment 8397108 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17653

Yes, you can just drop them in, the build system allows for specifying I believe GAIA_DEV_PIXELS_PER_PX to set the type of icons that will be built in to the app zip files for deployment.

For these sorts of pull requests, I mostly just confirm the names are correct since I do not have a hidpi device to test.

On the naming thing, this pull request seems to have a "checked" image but I do not see any existing "checked" image in the clock's images directory, so you may want to look into that. Otherwise, looks fine to me.

Comment 4

[Marcus Cavanaugh [:mcav]]

Hm, yes, you were right, checked needed to go in a different directory. Good catch.

master: https://github.com/mozilla-b2g/gaia/commit/24f53ad7eb48c6e773413687fa76c81983f926f3

Comment 5

[Gabriele Svelto [:gsvelto]]

Just a heads up on this bug. The new PNG assets that were committed here have not been properly re-compressed before commit; doing so will yield significant savings in terms of storage (~10x) so please do so in a follow up bug. You can recompress the assets using the png_recompress.sh script available in gaia. From gaia's root directory this command should do the job:

./tools/png_recompress.sh -v ./apps/clock/style/images/[e-mail] \
                             ./apps/clock/style/images/[e-mail] \
                             ./apps/clock/style/images/[e-mail] \
                             ./apps/clock/style/images/[e-mail] \
                             ./apps/clock/style/images/[e-mail] \
                             ./apps/clock/style/images/[e-mail] \
                             ./apps/clock/style/images/[e-mail] \
                             ./apps/clock/style/picker/images/icons/[e-mail]

To run the re-compression script you'll need the advancecomp and optipng 0.7.x packages installed. If you need further help feel free to ping/needinfo me.