Closed Bug 983076 Opened 6 years ago Closed 6 years ago

editor/libeditor/html/tests/mochitest.ini contains support files which are actually tests

Categories

(Core :: DOM: Editor, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: jmaher, Assigned: jmaher)

Details

Attachments

(1 file)

while fixing up the remaining b2g.json tests, we found that editor/libeditor/html/tests/mochitest.ini contains browserscope/* as support files.  In fact this is a whole sub testsuite inside of mochitest and there are two real test files in there.
Assignee: nobody → vaibhavmagarwal
Assignee: vaibhavmagarwal → jmaher
Comment on attachment 8390447 [details] [diff] [review]
do the right thing here and add a mochitest.ini for browserscope (1.0)

Review of attachment 8390447 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/tests/moz.build
@@ +4,4 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +MOCHITEST_MANIFESTS += ['browserscope/mochitest.ini', 'mochitest.ini']

nit: house style is one list entry per line, like:
MOCHITEST_MANIFESTS += [
    'browserscope/mochitest.ini',
    'mochitest.ini',
]
Attachment #8390447 - Flags: review?(ted) → review+
FWIW not all of those files are required for running the tests.

Also, why is this disabled on b2g?
this is fixing a previous port of the makefile rule which took the entire browserscope directory and put it in the tests folder.

I would love to reduce the scope of this.  This has never been run on b2g, it was always excluded, I am going for parity here.

This only came to our attention because it failed on b2g:
https://tbpl.mozilla.org/?tree=Try&startdate=2014-03-11&enddate=2014-03-14&rev=8c2dfae080a2

here is the log file from debug 12 (same failure as opt 8):
https://tbpl.mozilla.org/php/getParsedLog.php?id=36026917&tree=Try#error0
(In reply to comment #4)
> this is fixing a previous port of the makefile rule which took the entire
> browserscope directory and put it in the tests folder.
> 
> I would love to reduce the scope of this.  This has never been run on b2g, it
> was always excluded, I am going for parity here.
> 
> This only came to our attention because it failed on b2g:
> https://tbpl.mozilla.org/?tree=Try&startdate=2014-03-11&enddate=2014-03-14&rev=8c2dfae080a2
> 
> here is the log file from debug 12 (same failure as opt 8):
> https://tbpl.mozilla.org/php/getParsedLog.php?id=36026917&tree=Try#error0

Is there a bug on file for that?  Fixing bug 946646 should enable us to use this test, and we can just do the right thing and disable the parts of the test which require clipboard.  Disabling tests like this without filing bugs is... less than ideal. :(
https://hg.mozilla.org/mozilla-central/rev/858c8264e31c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.