Closed
Bug 983077
Opened 10 years ago
Closed 10 years ago
[MADAI][FMRadio] @2.25x assets update for FMRadio
Categories
(Firefox OS Graveyard :: Gaia::FMRadio, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: HHuang, Assigned: steveck)
References
Details
Attachments
(4 files, 1 obsolete file)
popup-texture.png
No description provided.
|
||
Comment 1•10 years ago
|
||
This needs to be assigned for implementation so, similar to other bugs, I'm flagging Steve Chung first for time zone coordination. Steve, please reassign as appropriate but we do need to know that someone is on point for implementation. Thanks!
Flags: needinfo?(schung)
|
|
||
Comment 2•10 years ago
|
||
This needs to be assigned for implementation so, similar to other bugs, I'm flagging Steve Chung first for time zone coordination. Steve, please reassign as appropriate but we do need to know that someone is on point for implementation. Thanks!
|
Assignee | |
Comment 3•10 years ago
|
||
Hi Helen, this image seems missed in the zip. Could you provide it? Thanks.
Flags: needinfo?(schung) → needinfo?(hhuang)
|
Reporter | |
Comment 4•10 years ago
|
||
Hi Steve, popup-texture@2.25x.png has updated. Please check it, thanks.
Flags: needinfo?(hhuang)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Hi Tim, I update these assets with recompressed result. Please re-assign if you think we have better candidate for reviewing, thanks.
Attachment #8400431 -
Flags: review?(timdream)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → schung
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8400431 [details] [review] Link to github Yes, I can help review. https://github.com/steveck-chung/gaia/blob/f59c72af6c5882a51d199c9b9c803d8b25dfffba/apps/fm/style/images/toggle-fav-star-pressed%402.25x.png This image is broken. I didn't check for missing images.
Attachment #8400431 -
Flags: review?(timdream)
|
|
Assignee | |
Comment 7•10 years ago
|
||
Comment on attachment 8400431 [details] [review] Link to github https://github.com/mozilla-b2g/gaia/pull/17878
|
|
Assignee | |
Comment 8•10 years ago
|
||
I update the lib for png compressing and re-generate png again. It looks fine on local... :-/
Attachment #8400431 -
Attachment is obsolete: true
Attachment #8400495 -
Flags: review?(timdream)
|
|
||
Comment 9•10 years ago
|
||
Comment on attachment 8400495 [details] [review] Link to github I'll take your word for it!
Attachment #8400495 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 10•10 years ago
|
||
Thanks! in master: b3e3eb1d5b46d34cdd6a520c95e2db68c78b7253
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•